-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added vi style scrolling (hjkl). #35
base: master
Are you sure you want to change the base?
Conversation
I gave this a quick try - when editing a text and then pressing esc, cursor keys work just fine, but for |
@The-Compiler You're right. I'll see if I can figure out the code base a bit more and fix the issue you just identified. Any guidance and pointers would be appreciated if you could provide any. I'm not very familiar with the codebase or have extensive experience working with GTK. I just hacked this change together very quickly as a proof of concept more than anything. |
For this to be integrated, it would have to be an option. i.e.
…-- add an option to the config file to load them at run time
-- disabled by default
--dmg
On Wed, Apr 12, 2017 at 9:37 PM, Varun ***@***.***> wrote:
@The-Compiler <https://github.com/The-Compiler> You're right. I'm not
very familiar with the codebase or have extensive experience working with
GTK. I just hacked these change together very quickly as a proof of concept
more than anything.
I see if I can figure out the code base a bit more and fix the issue you
just identified. Any guidance and pointers would be appreciated if you
could provide any.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#35 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAKM8LPVZo1ZYiJodPavIp0kJU5xJ7T0ks5rvaaKgaJpZM4M8PaJ>
.
--
--dmg
---
Daniel M. German
http://turingmachine.org
|
I'm afraid I can't help either - I just started contributing a few small things some weeks ago 😉 |
I recommend you look at the way the "space" and "shift space" are handled
to do scrolling
…On Wed, Apr 12, 2017 at 9:46 PM, Florian Bruhin ***@***.***> wrote:
I'm afraid I can't help either - I just started contributing a few small
things some weeks ago 😉
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#35 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAKM8Ef5stBBnHlW2j3WxyXypzwdY1_Uks5rvaiygaJpZM4M8PaJ>
.
--
--dmg
---
Daniel M. German
http://turingmachine.org
|
@dmgerman Hey, it's been a while, but I managed to get the option integrated. How is this repo related to the sourceforge hosted one? Does this one feed into sourceforge every so often? Should I just submit my patch there instead of here? I have not updated this PR with my changes. And I haven't looked at the bug The Compiler reported with text entry. |
@The-Compiler I noticed that issue is also present with Shift/Space after entering text and pressing escape. You can work around it by pressing the cursor keys and then everything else seems to work correctly after that. Not sure the reason for only the cursor keys working after entering text, dmgerman, is this a known issue? I am using my patched version, so I hope this isn't any issue I've created with my changes |
No description provided.