Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added vi style scrolling (hjkl). #35

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

francium
Copy link

No description provided.

@The-Compiler
Copy link

I gave this a quick try - when editing a text and then pressing esc, cursor keys work just fine, but for hjkl I need to e.g. change the tool first.

@francium
Copy link
Author

francium commented Apr 13, 2017

@The-Compiler You're right. I'll see if I can figure out the code base a bit more and fix the issue you just identified. Any guidance and pointers would be appreciated if you could provide any.

I'm not very familiar with the codebase or have extensive experience working with GTK. I just hacked this change together very quickly as a proof of concept more than anything.

@dmgerman
Copy link
Owner

dmgerman commented Apr 13, 2017 via email

@The-Compiler
Copy link

I'm afraid I can't help either - I just started contributing a few small things some weeks ago 😉

@dmgerman
Copy link
Owner

dmgerman commented Apr 13, 2017 via email

@francium
Copy link
Author

francium commented Jun 30, 2018

@dmgerman Hey, it's been a while, but I managed to get the option integrated.

How is this repo related to the sourceforge hosted one? Does this one feed into sourceforge every so often? Should I just submit my patch there instead of here?

I have not updated this PR with my changes. And I haven't looked at the bug The Compiler reported with text entry.

@francium
Copy link
Author

@The-Compiler I noticed that issue is also present with Shift/Space after entering text and pressing escape. You can work around it by pressing the cursor keys and then everything else seems to work correctly after that. Not sure the reason for only the cursor keys working after entering text, dmgerman, is this a known issue? I am using my patched version, so I hope this isn't any issue I've created with my changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants