[FEATURE] add keepParameter option for domains #301
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
if you are using 2 domains for 3 languages, you need to have the L parameter present for the pagepath. Now you have a keepParameter option for the _DOMAINS configuration, to prevent realurl from unsetting the lang param
No, you do not. Path decoding only uses language variable. It is set here and later used at path decoding.
"The API" for realurl does not exist. And realurl always removed that var. So there is nothing about compatibility here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
if you are using 2 domains for 3 languages, you need to have the L parameter present for the pagepath. Now you have a keepParameter option for the _DOMAINS configuration, to prevent realurl from unsetting the lang param.
Example:
foobar.de/de/
foobar.de/en/
foobar.es
If you configure the _DOMAINS you loose the language param for page path decoding. To prevent this and leave the API backwards compatible, I've introduced a new option for the _DOMAINS section.