Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TASK] Redirect non-safe URLs the the safe notation #618

Open
wants to merge 1 commit into
base: development
Choose a base branch
from

Conversation

stucki
Copy link

@stucki stucki commented Apr 6, 2018

As explained in #482 RealUrl is case sensitive for non-cached URLs, but it accepts different case spelling for cached results.

Scenario:

  1. Open http://mysite/HOME/ => it fails
  2. Open http://mysite/home/ => page is loaded, cache is filled
  3. Open http://mysite/HOME/ again => page is loaded but does not redirect

This is problematic because it leads to duplicate URLs for the same content.

Solution: If convertToSafeString() returns a different result, mark the original path as expired and redirect to the safe URL. With this change, the request is redirected in step 1 of the above scenario (even if there's no result in the cache).

Closes #482
see also #617

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant