-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DistGB]Restore the gb_convert_single_dgl_partition of the public function in partition.py #7803
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@CfromBU pls resolve he conflicts first. just rebase on latest DGL master branch |
To trigger regression tests:
|
@CfromBU is this PR ready for review? pls fix the lint failure |
Rhett-Ying
reviewed
Sep 23, 2024
Rhett-Ying
approved these changes
Sep 25, 2024
@thvasilo could you help verify it with tomorrow's nightly build? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In PR https://github.com/dmlc/dgl/pull/7727 the public function
gb_convert_single_dgl_partition
was modified and its functionality was replaced by_convert_partition_to_graphbolt
. In this PR,_convert_partition_to_graphbolt
is renamed togb_convert_single_dgl_partition
to allow other project can use the function normally as before.This PR can resolve the issue https://github.com/dmlc/dgl/issues/7802.
Changes
Renaming the function
_convert_partition_to_graphbolt
togb_convert_single_dgl_partition
.Renaming the function
gb_convert_single_dgl_partition
to_convert_dgl_partition_to_gb
.