Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DistGB]Restore the gb_convert_single_dgl_partition of the public function in partition.py #7803

Merged
merged 54 commits into from
Sep 25, 2024

Conversation

CfromBU
Copy link
Collaborator

@CfromBU CfromBU commented Sep 18, 2024

Description

In PR https://github.com/dmlc/dgl/pull/7727 the public function gb_convert_single_dgl_partition was modified and its functionality was replaced by _convert_partition_to_graphbolt. In this PR, _convert_partition_to_graphbolt is renamed to gb_convert_single_dgl_partition to allow other project can use the function normally as before.

This PR can resolve the issue https://github.com/dmlc/dgl/issues/7802.

Changes

Renaming the function _convert_partition_to_graphbolt to gb_convert_single_dgl_partition .
Renaming the function gb_convert_single_dgl_partition to _convert_dgl_partition_to_gb .

@Rhett-Ying
Copy link
Collaborator

@CfromBU pls resolve he conflicts first. just rebase on latest DGL master branch

@Rhett-Ying Rhett-Ying self-requested a review September 18, 2024 12:13
@dgl-bot
Copy link
Collaborator

dgl-bot commented Sep 23, 2024

To trigger regression tests:

  • @dgl-bot run [instance-type] [which tests] [compare-with-branch];
    For example: @dgl-bot run g4dn.4xlarge all dmlc/master or @dgl-bot run c5.9xlarge kernel,api dmlc/master

@dgl-bot
Copy link
Collaborator

dgl-bot commented Sep 23, 2024

Commit ID: 27bb682

Build ID: 1

Status: ⚪️ CI test cancelled due to overrun.

Report path: link

Full logs path: link

@dgl-bot
Copy link
Collaborator

dgl-bot commented Sep 23, 2024

Commit ID: 16a606c

Build ID: 2

Status: ✅ CI test succeeded.

Report path: link

Full logs path: link

@Rhett-Ying Rhett-Ying linked an issue Sep 23, 2024 that may be closed by this pull request
@Rhett-Ying
Copy link
Collaborator

@CfromBU is this PR ready for review? pls fix the lint failure

@dgl-bot
Copy link
Collaborator

dgl-bot commented Sep 23, 2024

Commit ID: be716ee

Build ID: 3

Status: ✅ CI test succeeded.

Report path: link

Full logs path: link

@dgl-bot
Copy link
Collaborator

dgl-bot commented Sep 24, 2024

Commit ID: 53416c1

Build ID: 4

Status: ✅ CI test succeeded.

Report path: link

Full logs path: link

@Rhett-Ying
Copy link
Collaborator

@thvasilo could you help verify it with tomorrow's nightly build?

@Rhett-Ying Rhett-Ying merged commit adbefc6 into dmlc:master Sep 25, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PR removed public function from dgl.distributed.partition
3 participants