Fix rng for the column sampler. #10998
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trivialfis
commented
Nov 14, 2024
| @@ -233,7 +233,7 @@ class ColumnSampler { | |||
| }; | |||
|
|
|||
| inline auto MakeColumnSampler(Context const* ctx) { | |||
| std::uint32_t seed = common::GlobalRandomEngine()(); | |||
There was a problem hiding this comment.
For the longer term, we should remove this global rng.
|
cc @rongou Could you please help take a look when you have a spare moment? |
hcho3
approved these changes
Nov 18, 2024
rongou
approved these changes
Nov 18, 2024
trivialfis
added a commit
to trivialfis/xgboost
that referenced
this pull request
Nov 19, 2024
trivialfis
added a commit
that referenced
this pull request
Nov 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GlobalRandomClose #10997 .