Skip to content

Commit

Permalink
Set processing version as integer
Browse files Browse the repository at this point in the history
  • Loading branch information
vkuznet committed Mar 18, 2022
1 parent 4e33708 commit 8fd2f2f
Show file tree
Hide file tree
Showing 4 changed files with 32 additions and 7 deletions.
13 changes: 10 additions & 3 deletions src/python/WMComponent/DBS3Buffer/DBSBufferBlock.py
Original file line number Diff line number Diff line change
Expand Up @@ -232,10 +232,17 @@ def setProcessingVer(self, procVer):
Set the block's processing version.
"""
# compatibility statement for old style proc ver (still needed ?)
if procVer.count("-") == 1:
self.data["processing_era"]["processing_version"] = procVer.split("-v")[1]
pver = procVer
if isinstance(pver, str) or isinstance(pver, bytes):
procVer = int(pver)
elif isinstance(pver, int):
procVer = pver
elif pver == None:
procVer = 0
else:
self.data["processing_era"]["processing_version"] = procVer
msg = "Provided procVer=%s of type %s cannot be converted to int" % (procVer, type(procVer))
raise Exception(msg)
self.data["processing_era"]["processing_version"] = procVer

self.data["processing_era"]["create_by"] = "WMAgent"
self.data["processing_era"]["description"] = ""
Expand Down
12 changes: 10 additions & 2 deletions src/python/WMComponent/DBS3Buffer/DBSBufferFile.py
Original file line number Diff line number Diff line change
Expand Up @@ -387,8 +387,16 @@ def setProcessingVer(self, ver):
Set the era
"""

self['processingVer'] = ver
if isinstance(ver, str) or isinstance(ver, bytes):
procVer = int(ver)
elif isinstance(ver, int):
procVer = ver
elif ver == None:
procVer = 0
else:
msg = "Provided procVer=%s of type %s cannot be converted to int" % (ver, type(ver))
raise Exception(msg)
self['processingVer'] = procVer
return

def setAcquisitionEra(self, era):
Expand Down
12 changes: 11 additions & 1 deletion src/python/WMCore/WMSpec/WMWorkload.py
Original file line number Diff line number Diff line change
Expand Up @@ -956,7 +956,17 @@ def setProcessingVersion(self, processingVersions):
task.setProcessingVersion(processingVersions, stepChainMap=stepNameMapping)

self.updateLFNsAndDatasets()
self.data.properties.processingVersion = processingVersions
if isinstance(processingVersions, str) or isinstance(processingVersions, bytes):
procVer = int(processingVersions)
elif isinstance(processingVersions, int):
procVer = processingVersions
elif isinstance(processingVersions, dict) or isinstance(processingVersions, list):
procVer = processingVersions
else:
msg = "Provided procVer=%s of type %s cannot be converted to int" \
% (processingVersions, type(processingVersions))
raise Exception(msg)
self.data.properties.processingVersion = procVer
return

def setProcessingString(self, processingStrings):
Expand Down
2 changes: 1 addition & 1 deletion test/python/WMComponent_t/DBS3Buffer_t/DBSBufferFile_t.py
Original file line number Diff line number Diff line change
Expand Up @@ -947,7 +947,7 @@ def testProperties(self):
configContent="MOREGIBBERISH")
testFileA.setDatasetPath("/Cosmics/CRUZET09-PromptReco-v1/RECO")
testFileA.setValidStatus(validStatus="VALID")
testFileA.setProcessingVer(ver="ProcVer")
testFileA.setProcessingVer(ver="123")
testFileA.setAcquisitionEra(era="AcqEra")
testFileA.setGlobalTag(globalTag="GlobalTag")
testFileA.setDatasetParent(datasetParent="Parent")
Expand Down

0 comments on commit 8fd2f2f

Please sign in to comment.