Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIx default value for processing version #11059

Merged
merged 1 commit into from
Mar 29, 2022

Conversation

vkuznet
Copy link
Contributor

@vkuznet vkuznet commented Mar 29, 2022

Fixes #10844

Status

ready

Description

Change default values of processingVer in various places of WMCore codebase

Is it backward compatible (if not, which system it affects?)

MAYBE

Related PRs

Complement to #11043

External dependencies / deployment changes

@vkuznet
Copy link
Contributor Author

vkuznet commented Mar 29, 2022

Alan, turns out WMCore has plenty of processingVer defaults pointed to None. I scan WMCore code for them, based on jenkins test failures and I think I identified the final set, unless the default values of processingVer at a different lines. Please include this PR in jenkins tests and we will see how it is going.

@cmsdmwmbot
Copy link

Jenkins results:

  • Python3 Unit tests: succeeded
    • 7 tests added
    • 1 changes in unstable tests
  • Python3 Pylint check: failed
    • 12 warnings and errors that must be fixed
    • 6 warnings
    • 101 comments to review
  • Pylint py3k check: succeeded
  • Pycodestyle check: succeeded

Details at https://cmssdt.cern.ch/dmwm-jenkins/view/All/job/DMWM-WMCore-PR-test/12966/artifact/artifacts/PullRequestReport.html

@amaltaro
Copy link
Contributor

Thanks Valentin. Tests are still running.

As discussed in our weekly meeting last Monday, pull requests do not get added to the quarterly GH project (only GH issues), so I'm removing it. The "BUG" label doesn't need to be added to the code changes as well, it's usually set only for the issue.

@amaltaro amaltaro removed the BUG label Mar 29, 2022
@vkuznet
Copy link
Contributor Author

vkuznet commented Mar 29, 2022

Alan, thanks for corrections, I still need to get use to the rules, I did it automatically without thinking too much :) Meanwhile, the pylint test fails but not due to changes I made and I feel uncomfortable to change code based on proposed pylint suggestions as it is not related to the fix. Please clarify if pylint changes will still be needed.

Copy link
Contributor

@amaltaro amaltaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, Valentin! We are back to 45 permanent failures in the oracle baseline unit tests.

@amaltaro amaltaro merged commit fa033fa into dmwm:master Mar 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ensure correct data-type values in DBS injection requests
3 participants