Change the data_tier_name relgexp in the lexicon to allow numbers. #109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vkuznet
requested changes
Mar 20, 2024
There was a problem hiding this comment.
Todor, it is not sufficient as I defined positive and negative expressions in other json files. They are used in unit tests, e.g. please see lexicon_writer_negative.json and its definition:
"data_tier_name": [
"123",
"lower"
],
which will test numbers and now numbers are allowed, so I would expect that unit test will fail. Please complement this PR with make test results, and pay attention to negative/positive tests. I think you must adjust them too.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #108