[Feat#22] FCM을 활용한 알림 시스템 구현 #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Starlight258
approved these changes
Feb 9, 2024
FacerAin
changed the title
FacerAin
commented
Feb 15, 2024
|
|
||
| @Bean | ||
| FirebaseMessaging firebaseMessaging() throws IOException { | ||
| ClassPathResource resource = new ClassPathResource("timeet-firebase-adminsdk.json"); |
There was a problem hiding this comment.
firebase 설정과 관련하여 application.yml과 통합을 고려하였는데,
FirebaseApp 구현체에서 기본적으로 json 파일을 불러오는 형태를 사용하여, 해당 구현을 따랐습니다!
| import java.lang.annotation.Target; | ||
| import org.springframework.security.core.annotation.AuthenticationPrincipal; | ||
|
|
||
| @Target({ElementType.PARAMETER, ElementType.ANNOTATION_TYPE}) |
There was a problem hiding this comment.
Spring security 관련하여
access 정보로부터 member 정보 불러올 때 가독성과 유지보수를 높이기 위해 다음과 같이 custom annotation을 사용하였는데, annotation으로 인한 side-effect나 단점이 없을지 궁금합니다
There was a problem hiding this comment.
코드 중복도 줄이고 정말 좋은 방법이네요!
저도 만든 어노테이션 잘 활용해보겠습니다 :)
|
LTGM :) |
Starlight258
approved these changes
Feb 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔗 Linked Issue
resolved: #22
🛠 개발 기능
🧩 해결 방법
/resources/timeet-firebase-adminsdk.json파일 추가가 필요합니다.🔍 리뷰 포인트
📋 Code Review Priority Guideline