Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

signtoken의 social type 추출한는 방법 변경 #45 #47

Merged
merged 1 commit into from
Feb 23, 2024
Merged

signtoken의 social type 추출한는 방법 변경 #45 #47

merged 1 commit into from
Feb 23, 2024

Conversation

strangehoon
Copy link
Member

📕 연관 이슈 번호

#45

📙 작업 내용

구현 내용 및 작업 했던 내역

  • [o] sign 토큰에서 social type 추출 로직 수정

📗 논의 사항

PR을 볼 때 주의깊게 봐야하거나 말하고 싶은 점

  • 특이사항1
  • 특이사항2

📘 체크리스트

  • [o] 본인을 Assign해주시고, 본인을 제외한 백엔드 개발자를 Reviewer로 지정해주세요.
  • [o] 라벨 체크해주세요.
  • [o] .yml 파일 수정 내용이 있다면 공유해주세요.

@strangehoon strangehoon self-assigned this Feb 22, 2024
@github-actions GitHub Actions
Copy link

Test Results

 79 files   79 suites   5s ⏱️
113 tests 112 ✅ 1 💤 0 ❌
114 runs  113 ✅ 1 💤 0 ❌

Results for commit ef1eab1.

woo0doo
woo0doo approved these changes Feb 23, 2024
View reviewed changes
Copy link
Member

@woo0doo woo0doo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@strangehoon strangehoon merged commit c363cc3 into develop Feb 23, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@woo0doo woo0doo woo0doo approved these changes

Assignees

@strangehoon strangehoon

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@strangehoon @woo0doo