Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor: domain entity 분리 #29

Merged
merged 7 commits into from
Aug 5, 2024

Conversation

Jaewon-pro
Copy link
Member

@Jaewon-pro Jaewon-pro commented Aug 2, 2024

🔗 이슈 연결

🚀 구현한 API

  • X

💡 반영할 내용 및 변경 사항 요약

  • domain 패키지에서 jpa entity 클래스들을 분리합니다.

🔍 리뷰 요청/참고 사항

  • 스크럼때 말씀드린 내용인데, 보시고 다른 점이나 수정했으면 하는 사항 있으면 말씀해주세요!

  • Apple 로그인 개발이 거의 다 된걸로 알고 있는데,
    apple 로그인 기능 개발 머지되고 이 PR을 병합하면 좋을 것 같아요.

  • apple 로그인 머지됐으니 리뷰 부탁드려요

@Jaewon-pro Jaewon-pro requested a review from hee9841 August 2, 2024 04:24
@Jaewon-pro Jaewon-pro self-assigned this Aug 2, 2024
@Jaewon-pro Jaewon-pro force-pushed the feature/#28/domain-entity-separation branch from 3bec614 to 83a2815 Compare August 5, 2024 03:04
Copy link
Collaborator

@hee9841 hee9841 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셨습니다 👍 👍

@Jaewon-pro Jaewon-pro merged commit a4777e1 into main Aug 5, 2024
1 check passed
@Jaewon-pro Jaewon-pro deleted the feature/#28/domain-entity-separation branch August 5, 2024 03:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Domain, Entity 분리
2 participants