Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: oauth 로그인 시 id token에 이메일 필드가 없는 경우 에러 타입 변경 #308

Merged
merged 1 commit into from
Nov 18, 2024
Merged

Fix: oauth 로그인 시 id token에 이메일 필드가 없는 경우 에러 타입 변경 #308

merged 1 commit into from
Nov 18, 2024

Conversation

WonSteps
Copy link
Member

🔗 이슈 연결

🚀 구현한 API

  • x

💡 반영할 내용 및 변경 사항 요약

  • id token에 이메일 필드가 없는 경우, FAILED_AUTHENTICATION에서 EMAIL_NOT_FOUND_IN_ID_TOKEN을 반환하도록 수정합니다.
  • BusinessException 대신 AuthException을 사용하도록 수정합니다.

🔍 리뷰 요청/참고 사항

@WonSteps WonSteps self-assigned this Nov 18, 2024
@WonSteps WonSteps requested a review from hee9841 November 18, 2024 07:45
hee9841
hee9841 approved these changes Nov 18, 2024
View reviewed changes
Copy link
Collaborator

@hee9841 hee9841 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셨습니다.😄

@WonSteps WonSteps merged commit f3cfadb into main Nov 18, 2024
1 check passed
@WonSteps WonSteps deleted the fix/#306/oauth-email branch November 18, 2024 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hee9841 hee9841 hee9841 approved these changes

Assignees

@WonSteps WonSteps

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

로그인 시, 이메일, 이름 정보를 찾을 수 없는 경우에 반환하는 응답 코드 변경
2 participants
@WonSteps @hee9841