Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat: 애플 로그인 구현 #35

Merged
merged 20 commits into from
Aug 5, 2024
Merged

Feat: 애플 로그인 구현 #35

merged 20 commits into from
Aug 5, 2024

Conversation

hee9841
Copy link
Collaborator

@hee9841 hee9841 commented Aug 3, 2024 •
edited
Loading

🔗 이슈 연결

🚀 구현한 API

  • POST /api/v1/auth/oauth

💡 반영할 내용 및 변경 사항 요약

  • 로그인 및 회원가입 API를 새롭게 추가 합니다.
  • 애플 로그인 및 회원가입 시 퍼블릭키를 생성해 토큰을 파싱합니다.

🔍 리뷰 요청/참고 사항

  • Exception 처리 괜찮은지 확인해 주세요.
  • 다른 소셜 로그인 확장을 생각해서 추상화를 진행했는데 패키지 위치 등 괜찮은지 확인 부탁드립니다.

@hee9841 hee9841 self-assigned this Aug 3, 2024
@hee9841 hee9841 linked an issue Aug 3, 2024 that may be closed by this pull request
소셜 로그인 구현 #3
Closed
@hee9841 hee9841 closed this Aug 3, 2024
@hee9841 hee9841 changed the title postgis database-platform설정 변경 Feat: 애플 로그인 구현 Aug 4, 2024
@hee9841 hee9841 reopened this Aug 4, 2024
@hee9841 hee9841 closed this Aug 4, 2024
hee9841 and others added 2 commits August 5, 2024 00:18
@hee9841
Fix: postgis database-platform deprecated 제거 (#36)
3c2e445 
* Chore: database-platform deprecated 이슈로 변경

* Fix: database-platform, database 설정 삭제
@hee9841
Fix: Map unchecked or unsafe operations fix
ddcc837
@hee9841 hee9841 reopened this Aug 4, 2024
@hee9841 hee9841 closed this Aug 4, 2024
@hee9841 hee9841 reopened this Aug 4, 2024
@Jaewon-pro
Copy link
Member

Jaewon-pro commented Aug 4, 2024 •
edited
Loading

  1. test/resources/application.yml에 apple public key url이 없어서 테스트에 실패하는데,
    테스트용 apple public key url을 위에 언급한 파일에 main/resources/application.yml이랑 똑같게 추가해주세요

    • 제 생각엔 apple public key url은 공개되어 있으니 env에 추가하지 말고,
      main/resources/application.yml에 key url을 바로 적으면 좋을 것 같아요.

  2. main 브랜치로 최신화 해주세요.

Jaewon-pro
Jaewon-pro reviewed Aug 4, 2024
View reviewed changes
src/main/java/com/dnd/runus/auth/oidc/provider/OidcProvider.java Outdated Show resolved Hide resolved
src/main/java/com/dnd/runus/auth/oidc/provider/OidcProviderFactory.java Outdated Show resolved Hide resolved
src/main/java/com/dnd/runus/auth/oidc/provider/OidcProviderFactory.java Outdated Show resolved Hide resolved
src/main/java/com/dnd/runus/auth/oidc/provider/impl/AppleAuthProvider.java Outdated Show resolved Hide resolved
src/main/java/com/dnd/runus/domain/login/controller/SignController.java Outdated Show resolved Hide resolved
src/main/java/com/dnd/runus/domain/login/service/LoginService.java Outdated Show resolved Hide resolved
src/main/java/com/dnd/runus/domain/login/service/LoginService.java Outdated Show resolved Hide resolved
src/main/java/com/dnd/runus/domain/login/service/LoginService.java Outdated Show resolved Hide resolved
src/main/java/com/dnd/runus/domain/member/entity/SocialProfile.java Outdated Show resolved Hide resolved
@hee9841
Style: login 패키지 명 변경
05fd88b
@hee9841
Fix : PR 수정 사항 적용
b91bd78 
- DecodeUtils 삭제
- getClaims 리팩터링
- OidcProviderFactory init 메서드 삭제
- 로그인,회원가입 관련 도메인 네이밍 변경
- 불필요한 print 제거
@hee9841
Fix : 회원가입 request dto 클래스 명 변경
e9bd960
Jaewon-pro
Jaewon-pro approved these changes Aug 5, 2024
View reviewed changes
Copy link
Member

@Jaewon-pro Jaewon-pro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

소셜 로그인 작업 고생하셨습니다 👍

@hee9841 hee9841 merged commit 2b023fa into main Aug 5, 2024
1 check passed
@hee9841 hee9841 added the feature 기능 추가 label Aug 5, 2024
@hee9841 hee9841 deleted the feature/#3/apple-login branch August 5, 2024 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jaewon-pro Jaewon-pro Jaewon-pro approved these changes

Assignees

@hee9841 hee9841

Labels
feature 기능 추가
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

소셜 로그인 구현
2 participants
@hee9841 @Jaewon-pro