Feat: RunningRecord controller record 추가 api 추가 #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hee9841
requested changes
Aug 7, 2024
| // FIXME: badge에 left join해서 같이 조회하기 | ||
| Member member = | ||
| memberRepository.findById(memberId).orElseThrow(() -> new NotFoundException(Member.class, memberId)); | ||
| // TODO: 챌린지 기능 추가 후 수정 |
There was a problem hiding this comment.
이 부분은 스크럼때, 여기 이슈에서 논의해보면 좋을 것 같아요!
- 오늘의 챌린지 기능 구현 #39
- 필요한 기능 정리
- 테이블 구조
src/main/java/com/dnd/runus/presentation/v1/running/RunningRecordController.java
Outdated
Show resolved
Hide resolved
...ain/java/com/dnd/runus/presentation/v1/running/dto/response/RunningRecordSavingResponse.java
Outdated
Show resolved
Hide resolved
src/main/java/com/dnd/runus/application/running/RunningRecordService.java
Show resolved
Hide resolved
hee9841
approved these changes
Aug 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔗 이슈 연결
🚀 구현한 API
api/v1/running-records: 혼자 뛰기 러닝 기록 추가💡 반영할 내용 및 변경 사항 요약
RunningRecordServiceaddRunningRecord 메서드에서는 request 값이 올바른지 검증하고 값을 저장해요RunningEmoji에 client와 정의한 enum 이름에 맞게 수정해요🔍 리뷰 요청/참고 사항
MemberEntity에Badge엔티티가 없어서, fetch join을 사용할 수 없어요.그래서 JPQL을 사용해서 dto projection하려니, 문자열로 SQL을 적는거랑 다름이 없는 것 같아요.