Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: suspense 적용 #114

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from
Draft

feat: suspense 적용 #114

wants to merge 5 commits into from

Conversation

SujinKim1127
Copy link
Member

@SujinKim1127 SujinKim1127 commented Sep 10, 2024

api/api.ts

/**
 *
 * @export
 * @interface PageResponseQuestionPostSimpleResponse
 */
export interface PageResponseQuestionPostSimpleResponse {
   /**
    *
    * @type {Array<QuestionPostSimpleResponse>}
    * @memberof PageResponseQuestionPostSimpleResponse
    */
   content: Array<QuestionPostSimpleResponse>
   /**
    *
    * @type {number}
    * @memberof PageResponseQuestionPostSimpleResponse
    */
   size?: number
   /**
    *
    * @type {boolean}
    * @memberof PageResponseQuestionPostSimpleResponse
    */
   hasNext?: boolean
}

여기서 content의 Optional을 지워줘야

src/clientPages/search/ui/ClientSearchPage.tsx

            {searchQuestionsData.content.map((question) => {
               return (
                  <QuestionCard data={question} key={question.questionPostId} />
               )
            })}

여기서 undefined 에러가 사라지는데

왜 interface에서 optional 삭제해야 undefined 에러가 없어지는지 모르겠네요 🥲

Copy link

vercel bot commented Sep 10, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
dnd-11th-3-frontend-gmi-design-system ❌ Failed (Inspect) Sep 10, 2024 4:02am

Copy link

netlify bot commented Sep 10, 2024

Deploy Preview for gongmuin failed. Why did it fail? →

Name Link
🔨 Latest commit 25de228
🔍 Latest deploy log https://app.netlify.com/sites/gongmuin/deploys/66dfc4ebda42b50009175532

@SujinKim1127 SujinKim1127 marked this pull request as draft September 11, 2024 06:22
Base automatically changed from feat/#112 to main September 26, 2024 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant