Avoid stack overflow when self-referential elemetns present, only use… #218
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… first ID
idattribute must be unique per document. However, SVGs in the wild don't necessarily do this. Browsers seem to handle this by taking the first instance of an ID and ignoring subsequent ones. This patch changes behavior so that only the firstidis used instead of the last one.useelement that tries to use itself doesn't make sense. This patch detects when auseelement tries to use itself and ignores that, which prevents a later stack overflow issue.Fixes dnfield/flutter_svg#997