Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create CertificatePrivateKey class instead of combining into CertificateBundle #171

Merged
merged 4 commits into from
Mar 12, 2024
Merged

Create CertificatePrivateKey class instead of combining into CertificateBundle #171

merged 4 commits into from
Mar 12, 2024

Conversation

ggalmazor
Copy link
Contributor

Fixes #118

In this PR:

  • Extract the privateKey attribute from CertificateBundle into its own class
  • Return a CertificatePrivateKey response in the Certificates.getCertificatePrivateKey endpoint

@ggalmazor ggalmazor requested a review from DXTimer March 12, 2024 10:24
@ggalmazor ggalmazor self-assigned this Mar 12, 2024
@ggalmazor ggalmazor added the bug label Mar 12, 2024
@ggalmazor ggalmazor mentioned this pull request Mar 12, 2024
Closed
@ggalmazor ggalmazor removed the request for review from DXTimer March 12, 2024 10:28
@ggalmazor ggalmazor force-pushed the change/create_cert_private_key_class branch from 2e77800 to ad5655a Compare March 12, 2024 10:30
@ggalmazor ggalmazor force-pushed the change/create_cert_private_key_class branch from ad5655a to bb5b223 Compare March 12, 2024 10:31
@ggalmazor ggalmazor merged commit c21b726 into main Mar 12, 2024
1 check passed
@ggalmazor ggalmazor deleted the change/create_cert_private_key_class branch March 12, 2024 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@ggalmazor ggalmazor

Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Change Certificates
1 participant
@ggalmazor