feat: ✨ Ajout de la variante "Mise en avant" du composant DsfrNewsLetter #598
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vincentlaine
force-pushed
the
feat/newsletterCallout
branch
from
4cebfd6
to
56b26c4
Compare
laruiss
previously approved these changes
Aug 31, 2023
laruiss
reviewed
Aug 31, 2023
Comment on lines
49
to
53
| <button class="fr-btn" | ||
| :title="buttonTitle" | ||
| @click="buttonAction ? buttonAction($event) : () => {}" | ||
| > |
There was a problem hiding this comment.
Ne correspond pas à notre eslint
There was a problem hiding this comment.
@laruiss J'ai amend le commit ! Dit moi si ça te va.
vincentlaine
force-pushed
the
feat/newsletterCallout
branch
from
56b26c4
to
e2f88b0
Compare
vincentlaine
force-pushed
the
feat/newsletterCallout
branch
from
e2f88b0
to
1a6345e
Compare
laruiss
approved these changes
Sep 4, 2023
|
🎉 This PR is included in version 4.6.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
|
Je l’ai fusionnée, mais je n’aurais pas dû : la prochaine fois merci de partir de |
|
ah yes désolé ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.