Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding my new haiku Inner Wolf #2956

Merged
merged 4 commits into from
Nov 6, 2023
Merged

Adding my new haiku Inner Wolf #2956

merged 4 commits into from
Nov 6, 2023

Conversation

athosrsilva
Copy link
Contributor

No description provided.

ltagliaferri
ltagliaferri requested changes Oct 27, 2023
View reviewed changes
Copy link
Collaborator

@ltagliaferri ltagliaferri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for submitting this haiku! It looks like the file path isn't quite right — can you ensure that it is in the _haikus/ directory? Once you update the path we can merge this in.

Please note: maintainers will only go through one round of review, first reviews that are not sufficiently addressed will be closed and marked invalid. Also note that after more than two days of inactivity, pull requests are subject to being closed and marked invalid by maintainers.

@athosrsilva
Copy link
Contributor Author

Thank you for submitting this haiku! It looks like the file path isn't quite right — can you ensure that it is in the _haikus/ directory? Once you update the path we can merge this in.

Please note: maintainers will only go through one round of review, first reviews that are not sufficiently addressed will be closed and marked invalid. Also note that after more than two days of inactivity, pull requests are subject to being closed and marked invalid by maintainers.

Hello, the file was moved to "_haikus/" as required!

@athosrsilva
Copy link
Contributor Author

Thank you for submitting this haiku! It looks like the file path isn't quite right — can you ensure that it is in the _haikus/ directory? Once you update the path we can merge this in.

Please note: maintainers will only go through one round of review, first reviews that are not sufficiently addressed will be closed and marked invalid. Also note that after more than two days of inactivity, pull requests are subject to being closed and marked invalid by maintainers.

@ltagliaferri

ltagliaferri
ltagliaferri approved these changes Nov 6, 2023
View reviewed changes
Copy link
Collaborator

@ltagliaferri ltagliaferri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this haiku and for contributing to open source 🎉

@ltagliaferri ltagliaferri merged commit 4232f78 into do-community:main Nov 6, 2023
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ltagliaferri ltagliaferri ltagliaferri approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@athosrsilva @ltagliaferri