New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support all(?) of the landscape and portrait combinations #530

Merged

ndw merged 2 commits into docbook:main from ndw:iss-522

Oct 20, 2024

Contributor

ndw commented Oct 20, 2024 •

edited

Loading

My attempt to handle all of the various landscape and portrait combinations:

Portrait article, landscape table
Portrait article, draft section, landscape table
Landscape article, portrait table
Landscape article, draft section, portrait table
Portrait book, landscape table
Portrait book, draft chapter, landscape table
Landscape book, portrait table
Landscape book, draft chapter, portrait table

There's no practical test automation for PDF output, so I eyeballed it. The relevant tests are in src/test/resources/xml/orient-*.xml

Fix #522

ndw added 2 commits

October 20, 2024 13:25


          Support all(?) of the landscape and portrait combinations

c1a6e5a


          Add expected results (irrelevant HTML results, really)

8d55d74

ndw merged commit 06512d0 into docbook:main

4 checks passed

ndw deleted the iss-522 branch

October 20, 2024 14:39

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet