Skip to content
This repository has been archived by the owner on Jan 21, 2020. It is now read-only.

Pool controller #896

Merged
merged 4 commits into from
Apr 2, 2018
Merged

Pool controller #896

merged 4 commits into from
Apr 2, 2018

Conversation

chungers
Copy link
Contributor

@chungers chungers commented Apr 1, 2018

The PR is the pool controller

  • equivalent to the "Group" controller in managing a 'pool' of instances.
  • uses FSM to implement throttle/ parallelism
  • does not "overshoot" when provisioning when backends are too slow
  • can easily scale down to 0 (Scale Group size down to 0 #717)

Once the pool controller is stable and examples put together, the Group controller will be deprecated in favor of a consistent schema and controller implementation using finite state machines than using instance counts and polling.

asciicast

Signed-off-by: David Chung [email protected]

David Chung added 2 commits April 1, 2018 13:25
@codecov
Copy link

codecov bot commented Apr 1, 2018

Codecov Report

Merging #896 into master will decrease coverage by 0.06%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #896      +/-   ##
=========================================
- Coverage   48.56%   48.5%   -0.07%     
=========================================
  Files          84      84              
  Lines        7837    7837              
=========================================
- Hits         3806    3801       -5     
- Misses       3721    3725       +4     
- Partials      310     311       +1
Impacted Files Coverage Δ
pkg/rpc/mux/server.go 42.7% <0%> (-5.21%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5fc9c58...6d91c80. Read the comment docs.

David Chung added 2 commits April 1, 2018 22:55
@chungers chungers merged commit f931060 into docker-archive:master Apr 2, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant