Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify index munge for verification #80

Merged

Conversation

LaurentGoderre
Copy link
Member

@LaurentGoderre LaurentGoderre commented Sep 13, 2024

Preserves the image.ref.name annotation and set it to the first arch tag

@LaurentGoderre LaurentGoderre force-pushed the index-munging-verification branch 7 times, most recently from 71c79c1 to 91e427a Compare September 13, 2024 21:28
Copy link
Collaborator

@whalelines whalelines left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One question

meta.jq Outdated Show resolved Hide resolved
Preserves the image.ref.name annotatoon and set it to the first arch tag
@LaurentGoderre
Copy link
Member Author

@tianon much simpler now!

Copy link
Collaborator

@whalelines whalelines left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@LaurentGoderre
Copy link
Member Author

Copy link
Member

@tianon tianon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much nicer ❤️ 🚀

Given you're pointing us at an image, I'm going to assume that was pushed by crane push and these annotations are also not a problem there 😂 🤘

@tianon tianon merged commit cc821f3 into docker-library:main Sep 20, 2024
1 check passed
@LaurentGoderre
Copy link
Member Author

Yep! It is mimicking the push command from meta

@LaurentGoderre LaurentGoderre deleted the index-munging-verification branch September 20, 2024 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants