Merge pull request #5483 from robmry/ip-range-validation

Check that --ip-range is a CIDR address
docker · Sep 26, 2024 · c767b9b · c767b9b
2 parents daabb15 + 8fca0a1
commit c767b9b
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 0 deletions.
diff --git a/cli/command/network/create.go b/cli/command/network/create.go
@@ -163,6 +163,9 @@ func createIPAMConfig(options ipamOptions) (*network.IPAM, error) {
 	for _, r := range options.ipRanges {
 		match := false
 		for _, s := range options.subnets {
+			if _, _, err := net.ParseCIDR(r); err != nil {
+				return nil, err
+			}
 			ok, err := subnetMatches(s, r)
 			if err != nil {
 				return nil, err

diff --git a/cli/command/network/create_test.go b/cli/command/network/create_test.go
@@ -124,6 +124,15 @@ func TestNetworkCreateErrors(t *testing.T) {
 			},
 			expectedError: "no matching subnet for aux-address",
 		},
+		{
+			args: []string{"toto"},
+			flags: map[string]string{
+				"ip-range": "192.168.83.1-192.168.83.254",
+				"gateway":  "192.168.80.1",
+				"subnet":   "192.168.80.0/20",
+			},
+			expectedError: "invalid CIDR address: 192.168.83.1-192.168.83.254",
+		},
 	}
 
 	for _, tc := range testCases {