Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[27.x backport] Do not underline image name #5519

Merged
merged 1 commit into from
Oct 8, 2024

Conversation

thaJeztah
Copy link
Member

Blue text with underline looks too much as a hyperlink I can click on

(cherry picked from commit 1704089)

- What I did

Removed the underline from the blue image names. Blue text with underline looks too much as a hyperlink I can click on

Before:
Screenshot 2024-09-23 at 15 30 29

After:
Screenshot 2024-09-23 at 15 36 06

- Description for the changelog

- containerd image store:  do not underline names in `docker image ls --tree`.

- A picture of a cute animal (not mandatory but encouraged)

Blue text with underline looks too much as a hyperlink I can click on

Signed-off-by: Djordje Lukic <[email protected]>
(cherry picked from commit 1704089)
Signed-off-by: Sebastiaan van Stijn <[email protected]>
@thaJeztah thaJeztah added this to the 27.4.0 milestone Oct 8, 2024
@thaJeztah thaJeztah self-assigned this Oct 8, 2024
@codecov-commenter
Copy link

codecov-commenter commented Oct 8, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 59.78%. Comparing base (132ecbc) to head (4694fc8).
Report is 9 commits behind head on 27.x.

Additional details and impacted files
@@           Coverage Diff           @@
##             27.x    #5519   +/-   ##
=======================================
  Coverage   59.78%   59.78%           
=======================================
  Files         345      345           
  Lines       23442    23442           
=======================================
  Hits        14015    14015           
  Misses       8453     8453           
  Partials      974      974           

@thaJeztah thaJeztah merged commit cb3048f into docker:27.x Oct 8, 2024
108 checks passed
@thaJeztah thaJeztah deleted the 27.x_backport_no_underline branch October 8, 2024 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants