[master] rpm: remove Obsoletes for obsolete (selinux) packages #1155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove the obsoletes for `docker-ce-selinux`, `docker-engine-selinux`, and `docker-engine`. These were obsoleted in 2017 through 94943b4 > Mark docker-*-selinux pkgs as obsolete > > These are replaced by `container-selinux` on fedora-25 and centos-7. > Marking these packages as obsolete makes the installation process a bit > smoother, otherwise the user will have to manually uninstall the older > packages to install the new one. > > Also makes fedora24 use container-selinux which is now supports labeling > the `dockerd` binary correctly. Both CentOS 6/7 and Fedora 25 are EOL now, and these packages have not been published for a long time. Time to remove them, also to reduce some noise during builds; RPM build warnings: line 51: It's not recommended to have unversioned Obsoletes: Obsoletes: docker-ce-selinux line 52: It's not recommended to have unversioned Obsoletes: Obsoletes: docker-engine-selinux line 53: It's not recommended to have unversioned Obsoletes: Obsoletes: docker-engine Signed-off-by: Sebastiaan van Stijn <[email protected]>
Benehiko
approved these changes
Jan 24, 2025
|
Thanks! Jenkins went AWOL Yesterday, but looks like it's back; let me bring this one in |
thaJeztah
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the obsoletes for
docker-ce-selinux,docker-engine-selinux, anddocker-engine.These were obsoleted in 2017 through 94943b4
Both CentOS 6/7 and Fedora 25 are EOL now, and these packages have not been published for a long time. Time to remove them, also to reduce some noise during builds;
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)