Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add instructions for deploying DockerHub images #14932

Closed
wants to merge 1 commit into from

Conversation

syedsuhaib
Copy link

Add a note to clarify that we must add the full URI of images hosted on DockerHub because Docker ACI Integration by default looks only in Azure Container Registry.

Proposed changes

Without specifying the full URI of a docker image hosted in DockerHub, the docker run command currently fails in aci context with error "MoreImageRegistryCredentialsThanContainers" Message="More image registry credentials provided than containers in container group". Specifying the full URI resolves the issue. It may need a more thorough analysis and a considered decision at a project-level, however, updating the documentation to reflect only working examples is an immediate must.

Related issues (optional)

Based on this issue, the proposed changes in documentation are necessary to create a seamless experience for docker cli users.

Add a note to clarify that we must add the full URI of images hosted on DockerHub because Docker ACI Integration by default looks only in Azure Container Registry.
@netlify
Copy link

netlify bot commented Jun 13, 2022

Deploy Preview for docsdocker ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 874723e
🔍 Latest deploy log https://app.netlify.com/sites/docsdocker/deploys/62a75e168f06cb00092ec2f7
😎 Deploy Preview https://deploy-preview-14932--docsdocker.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@@ -106,6 +106,13 @@ $ docker context use myacicontext
$ docker run -p 80:80 nginx
```

> **Note**
>
> Unlike the Azure portal - which [does not require](https://stackoverflow.com/a/57454806) the full URI of DockerHub images - the Docker Azure Integration seems to default to Azure Container Registry in order to determine the source registry from where to pull the specified image(s). Therefore you may need to add the full URI of the image(s) if you are pulling from anywhere other than azurecr.io. In case of images hosted on DockerHub, you may therefore specify:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@syedsuhaib Thanks for the PR. Suggest we remove links to third-party sites from the Docs. ;)

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm sorry, maybe I'm missing something, but I can run an image that I just pushed on Docker hub (I pushed some nginx under my hub account) :

$  docker --context aci run gtardif/nginx-test
[+] Running 2/2
 ⠿ Group gracious-kare  Created                       4.8s
 ⠿ gracious-kare        Created                            20.8s
/docker-entrypoint.sh: /docker-entrypoint.d/ is not empty, will attempt to perform configuration
/docker-entrypoint.sh: Looking for shell scripts in /docker-entrypoint.d/
/docker-entrypoint.sh: Launching /docker-entrypoint.d/10-listen-on-ipv6-by-default.sh
10-listen-on-ipv6-by-default.sh: info: Getting the checksum of /etc/nginx/conf.d/default.conf
10-listen-on-ipv6-by-default.sh: info: Enabled listen on IPv6 in /etc/nginx/conf.d/default.conf
/docker-entrypoint.sh: Launching /docker-entrypoint.d/20-envsubst-on-templates.sh
/docker-entrypoint.sh: Launching /docker-entrypoint.d/30-tune-worker-processes.sh
/docker-entrypoint.sh: Configuration complete; ready for start up
2022/07/21 16:51:20 [notice] 19#19: using the "epoll" event method
2022/07/21 16:51:20 [notice] 19#19: nginx/1.23.1
2022/07/21 16:51:20 [notice] 19#19: built by gcc 10.2.1 20210110 (Debian 10.2.1-6) 
2022/07/21 16:51:20 [notice] 19#19: OS: Linux 5.10.102.2-microsoft-standard
2022/07/21 16:51:20 [notice] 19#19: getrlimit(RLIMIT_NOFILE): 1024:1048576
2022/07/21 16:51:20 [notice] 19#19: start worker processes
2022/07/21 16:51:20 [notice] 19#19: start worker process 48

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, it doesn't work for me either. and I don't understand to where I am supposed to get the URI from.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@syedsuhaib Thanks for the PR. Suggest we remove links to third-party sites from the Docs. ;)

I've removed the external link but the PR is now closed. I should perhaps open a new one now?

@usha-mandya usha-mandya requested a review from gtardif July 8, 2022 09:33
@usha-mandya
Copy link
Member

@gtardif Could you PTAL?

@xtianus79
Copy link

@gtardif @syedsuhaib @usha-mandya I think the correct way to do this is docker.io/nginx the server being docker.io <<< That is the only thing that worked for me. Finally.

@hcoona
Copy link

hcoona commented Oct 9, 2022

ping

@docker-robott
Copy link
Collaborator

Thanks for the pull request. We'd like to make our product docs better, but haven’t been able to review all the suggestions.
As our docs have also diverged, we do not have the bandwidth to review and rebase old pull requests.

If the updates are still relevant, review our contribution guidelines and rebase your pull request against the latest version of the docs, then mark it as fresh with a /remove-lifecycle stale comment.
If not, this pull request will be closed in 30 days. This helps our maintainers focus on the active pull requests.

Prevent pull requests from auto-closing with a /lifecycle frozen comment.

/lifecycle stale

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants