-
Notifications
You must be signed in to change notification settings - Fork 7.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding advisory warnings about docker-machine #9239
Conversation
Deploy preview for docsdocker ready! Built with commit 3697b94 |
I think this is ready for merge - not sure if I should be able to pass that jenkins check or if it's just restricted to collabs |
Thanks, I have just noticed that docker-machine's manual is under superseded products and tools, but as opposed to other products in that section, I could not find any information on what superseded docker-machine, nor why it was superseded. |
might be worth a mention or changing getting started too? https://docs.docker.com/get-started/part4/ |
Done, this PR now fixes #9262 |
Also another attempt to get the important tag working
Hi @hamiltont and @GPPassos Thank you for taking the time to request these changes. You are right, the instructions were not inline with current best practices. We just updated the whole guide, including the two parts you're discussing in this pr. |
@DawnWood-Docker please reopen. If you look at the changes you'll see that the bulk of this PR was focused on the documentation for docker machine, not on the get started guide. |
Ah, I see. We'll have to remove the get started updates. I'll take a look at the other files. Thanks, |
@DawnWood-Docker thanks! BTW, I've just removed the two commits that were editing the (old) getting started guide, so the PR now only targets the Docker Machine documentation |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Apologies for the delay
Thanks!
…On Mon, Nov 18, 2019, 5:22 PM Dawn-Docker ***@***.***> wrote:
Merged #9239 <#9239> into
master.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#9239>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AACKRZDBAP4NDVTMVIVUXXLQUMIT5ANCNFSM4IK4NZLQ>
.
|
@hamiltont Apologies, we'll have to revert the PR. We just want to finish evaluating the overall changes with Docker's split from Enterprise over the last week before we make any decisions on where Docker Machine is in its lifecycle. We should have an update for you soon. Thanks. |
Dang I'm sorry I thought that was settled. |
@usha-mandya no problem. Hopefully you'll come back and tell me docker has decided to support machine (since frankly it fits better in the non-enterprise use case where you're working with a very simple system via compose and want to spin up one server not 15 and not a kube) Please let me know if you need me to reopen the PR, or you are welcome to reopen it yourself it would just be great if someone would copy me on that new thread |
@usha-mandya Please let me know if you need me to reopen a new PR while this topic is still under consideration :-) |
@hamiltont We don't need a new PR at this stage. Thanks for your patience :) |
It's baffling to me that such a critical piece of tooling has been abandoned for this extended period of time whilst political nonsense plays out. Machine is a going concern as long as Docker is. |
@seffyroff I was confused too by "deprecation" of docker-machine which is the most useful thing even... It turns out now docker-machine is not needed anymore because of build-in ssh transport support. See here. So instead of docker-machine steps, the new procedure is something like:
From my testing today seems to work just as well as before, with added benefit of not needing to open a special port. |
Proposed changes
Adds advisory to docker-machine pages about maintenance - docker/machine#4537.
While it's reasonable that a project has to be shelved, most of the comments on that thread indicate that it's quite unreasonable there are no warnings about this in the official documentation. This PR aims to resolve that by ensuring anyone reading the docker-machine documentatin is aware of the project status and docker's recommendations
(Note: I tried to copy @shin- comments exactly in advistory text, if there is a different official docker position please just update the advisory text as needed)
Related issues (optional)
docker/machine#4537
docker/machine#3098 (referenced from examples/aws.md)