Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding advisory warnings about docker-machine #9239

Merged
merged 9 commits into from
Nov 18, 2019

Conversation

hamiltont
Copy link
Contributor

@hamiltont hamiltont commented Aug 11, 2019

Proposed changes

Adds advisory to docker-machine pages about maintenance - docker/machine#4537.

While it's reasonable that a project has to be shelved, most of the comments on that thread indicate that it's quite unreasonable there are no warnings about this in the official documentation. This PR aims to resolve that by ensuring anyone reading the docker-machine documentatin is aware of the project status and docker's recommendations

(Note: I tried to copy @shin- comments exactly in advistory text, if there is a different official docker position please just update the advisory text as needed)

Related issues (optional)

docker/machine#4537
docker/machine#3098 (referenced from examples/aws.md)

@GordonTheTurtle
Copy link

GordonTheTurtle commented Aug 11, 2019

Deploy preview for docsdocker ready!

Built with commit 3697b94

https://deploy-preview-9239--docsdocker.netlify.com

@hamiltont
Copy link
Contributor Author

I think this is ready for merge - not sure if I should be able to pass that jenkins check or if it's just restricted to collabs

@GPPassos
Copy link

Thanks, I have just noticed that docker-machine's manual is under superseded products and tools, but as opposed to other products in that section, I could not find any information on what superseded docker-machine, nor why it was superseded.

@pmcneil
Copy link

pmcneil commented Aug 23, 2019

might be worth a mention or changing getting started too? https://docs.docker.com/get-started/part4/

@hamiltont
Copy link
Contributor Author

might be worth a mention or changing getting started too? https://docs.docker.com/get-started/part4/

Done, this PR now fixes #9262

Also another attempt to get the important tag working
@Dawn-Wood
Copy link
Contributor

Hi @hamiltont and @GPPassos Thank you for taking the time to request these changes. You are right, the instructions were not inline with current best practices. We just updated the whole guide, including the two parts you're discussing in this pr.
Love to hear your feedback on the updated guide--https://docs.docker.com/get-started/.
I'm closing this pr but feel free to open another on the new guide if you find issues.

@Dawn-Wood Dawn-Wood closed this Oct 10, 2019
@hamiltont
Copy link
Contributor Author

@DawnWood-Docker please reopen. If you look at the changes you'll see that the bulk of this PR was focused on the documentation for docker machine, not on the get started guide.

@Dawn-Wood
Copy link
Contributor

Ah, I see. We'll have to remove the get started updates. I'll take a look at the other files. Thanks,
Dawn

@Dawn-Wood Dawn-Wood reopened this Oct 10, 2019
This reverts commit 6450d5d.

# Conflicts:
#	get-started/part4.md
This reverts commit d14a259.

# Conflicts:
#	get-started/part4.md
@hamiltont
Copy link
Contributor Author

@DawnWood-Docker thanks! BTW, I've just removed the two commits that were editing the (old) getting started guide, so the PR now only targets the Docker Machine documentation

Copy link
Contributor

@Dawn-Wood Dawn-Wood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Apologies for the delay

@Dawn-Wood Dawn-Wood merged commit 5b918f7 into docker:master Nov 18, 2019
@hamiltont
Copy link
Contributor Author

hamiltont commented Nov 19, 2019 via email

@usha-mandya
Copy link
Member

@hamiltont Apologies, we'll have to revert the PR.

We just want to finish evaluating the overall changes with Docker's split from Enterprise over the last week before we make any decisions on where Docker Machine is in its lifecycle. We should have an update for you soon. Thanks.

@Dawn-Wood
Copy link
Contributor

Dang I'm sorry I thought that was settled.

@hamiltont
Copy link
Contributor Author

@usha-mandya no problem. Hopefully you'll come back and tell me docker has decided to support machine (since frankly it fits better in the non-enterprise use case where you're working with a very simple system via compose and want to spin up one server not 15 and not a kube)

Please let me know if you need me to reopen the PR, or you are welcome to reopen it yourself it would just be great if someone would copy me on that new thread

@hamiltont
Copy link
Contributor Author

@usha-mandya Please let me know if you need me to reopen a new PR while this topic is still under consideration :-)

@usha-mandya
Copy link
Member

@hamiltont We don't need a new PR at this stage. Thanks for your patience :)

@seffyroff
Copy link

It's baffling to me that such a critical piece of tooling has been abandoned for this extended period of time whilst political nonsense plays out.

Machine is a going concern as long as Docker is.

@ivanistheone
Copy link

@seffyroff I was confused too by "deprecation" of docker-machine which is the most useful thing even... It turns out now docker-machine is not needed anymore because of build-in ssh transport support. See here.

So instead of docker-machine steps, the new procedure is something like:

  • Provision the remote host and sudo apt-get install docker.io (assuming Ubuntu 18.04)
  • Enable docker service to run on startup sudo systemctl enable docker (to start it run sudo systemctl start docker)
  • Add your user to docker group sudo usermod -aG docker user
  • On local machine export DOCKER_HOST=ssh://[email protected]

From my testing today seems to work just as well as before, with added benefit of not needing to open a special port.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants