Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump braces and @cypress/webpack-batteries-included-preprocessor #1979

Closed
wants to merge 7 commits into from

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Jun 11, 2024

Bumps braces to 3.0.3 and updates ancestor dependency @cypress/webpack-batteries-included-preprocessor. These dependencies need to be updated together.

Updates braces from 3.0.2 to 3.0.3

Commits

Updates @cypress/webpack-batteries-included-preprocessor from 2.4.1 to 3.0.3

Commits
  • 18ebb88 chore: release @​cypress/webpack-batteries-included-preprocessor-v3.0.3
  • 5e6be4a chore: release @​cypress/vue2-v2.1.1
  • c081a4f chore: release @​cypress/vue-v6.0.1
  • efcc71a chore: release @​cypress/vite-dev-server-v5.1.1
  • a8af6cc chore: release @​cypress/svelte-v2.0.1
  • eb0762c chore: release @​cypress/react18-v2.0.1
  • 478815e chore: release @​cypress/react-v8.0.2
  • 2b9c4ba chore: release @​cypress/puppeteer-v0.1.5
  • 6c9f40a chore: release @​cypress/mount-utils-v4.1.1
  • 0605604 chore: release @​cypress/grep-v4.0.2
  • Additional commits viewable in compare view

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
    You can disable automated security fix PRs for this repo from the Security Alerts page.

Bumps [braces](https://github.com/micromatch/braces) to 3.0.3 and updates ancestor dependency [@cypress/webpack-batteries-included-preprocessor](https://github.com/cypress-io/cypress). These dependencies need to be updated together.


Updates `braces` from 3.0.2 to 3.0.3
- [Changelog](https://github.com/micromatch/braces/blob/master/CHANGELOG.md)
- [Commits](micromatch/braces@3.0.2...3.0.3)

Updates `@cypress/webpack-batteries-included-preprocessor` from 2.4.1 to 3.0.3
- [Release notes](https://github.com/cypress-io/cypress/releases)
- [Changelog](https://github.com/cypress-io/cypress/blob/develop/CHANGELOG.md)
- [Commits](https://github.com/cypress-io/cypress/compare/@cypress/webpack-batteries-included-preprocessor-v2.4.1...@cypress/webpack-batteries-included-preprocessor-v3.0.3)

---
updated-dependencies:
- dependency-name: braces
  dependency-type: indirect
- dependency-name: "@cypress/webpack-batteries-included-preprocessor"
  dependency-type: direct:development
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot added dependencies Pull requests that update a dependency file javascript Pull requests that update Javascript code labels Jun 11, 2024
@dependabot dependabot bot requested review from a team, david4096, kathy-t and hyunnaye and removed request for a team June 11, 2024 08:51
@denis-yuen
Copy link
Member

high severity, but would affect user rather than server so moderate or low for us

@svonworl svonworl requested review from svonworl and denis-yuen June 25, 2024 00:42
@svonworl
Copy link
Contributor

This PR passes our test suite and, upon cursory inspection, doesn't appear to break the UI. There's a lot of dependency changes (see the package-lock.json diff), but I suppose that's probably pretty normal for node-based projects. Recommend merging.

Copy link
Member

@denis-yuen denis-yuen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree with reasoning, that said integration test 4 failed again, is it a known flakey test?

Copy link

codecov bot commented Jun 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 42.75%. Comparing base (e221a20) to head (2fc40c7).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #1979   +/-   ##
========================================
  Coverage    42.75%   42.75%           
========================================
  Files          371      371           
  Lines        11708    11708           
  Branches      2777     2777           
========================================
  Hits          5006     5006           
  Misses        4510     4510           
  Partials      2192     2192           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@svonworl svonworl requested a review from coverbeck June 25, 2024 18:50
@svonworl
Copy link
Contributor

Agree with reasoning, that said integration test 4 failed again, is it a known flakey test?

broken pcawg link, fixed in another pr

Copy link

@svonworl
Copy link
Contributor

@dependabot ignore braces

@dependabot dependabot bot closed this Jun 26, 2024
Copy link
Contributor Author

dependabot bot commented on behalf of github Jun 26, 2024

OK, I won't notify you about any of these dependencies again, unless you re-open this PR.

@dependabot dependabot bot deleted the dependabot/npm_and_yarn/multi-7d932a914c branch June 26, 2024 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file javascript Pull requests that update Javascript code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants