Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SEAB-6917: add Toil to Partner enum #2058

Closed
wants to merge 1 commit into from
Closed

Conversation

hyunnaye
Copy link
Contributor

@hyunnaye hyunnaye commented Feb 6, 2025

Description
This PR adds Toil as a partner.

Review Instructions
Try to post metrics with Toil as a partner and verify it works.

Issue
https://ucsc-cgl.atlassian.net/browse/SEAB-6917

Security
If there are any concerns that require extra attention from the security team, highlight them here.

Please make sure that you've checked the following before submitting your pull request. Thanks!

  • Check that your code compiles by running npm run build
  • Ensure that the PR targets the correct branch. Check the milestone or fix version of the ticket.
  • If this is the first time you're submitting a PR or even if you just need a refresher, consider reviewing our style guide
  • Do not bypass Angular sanitization (bypassSecurityTrustHtml, etc.), or justify why you need to do so
  • If displaying markdown, use the markdown-wrapper component, which does extra sanitization
  • Do not use cookies, although this may change in the future
  • Run npm audit and ensure you are not introducing new vulnerabilities
  • Do due diligence on new 3rd party libraries, checking for CVEs
  • Don't allow user-uploaded images to be served from the Dockstore domain
  • If this PR is for a user-facing feature, create and link a documentation ticket for this feature (usually in the same milestone as the linked issue). Style points if you create a documentation PR directly and link that instead.
  • Check whether this PR disables tests. If it legitimately needs to disable a test, create a new ticket to re-enable it in a specific milestone.

Copy link

sonarqubecloud bot commented Feb 7, 2025

Copy link

codecov bot commented Feb 7, 2025

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 41.81%. Comparing base (22e108e) to head (3eacada).

Files with missing lines Patch % Lines
src/app/shared/entry/platform-partner.pipe.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2058      +/-   ##
===========================================
- Coverage    41.81%   41.81%   -0.01%     
===========================================
  Files          390      390              
  Lines        12311    12312       +1     
  Branches      2945     2945              
===========================================
  Hits          5148     5148              
- Misses        4860     4861       +1     
  Partials      2303     2303              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@kathy-t kathy-t left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ticket has a hotfix milestone so I think this should go to the 2.13.4 hotfix branch

@hyunnaye hyunnaye changed the base branch from develop to hotfix/2.13.4 February 11, 2025 17:31
@hyunnaye hyunnaye changed the base branch from hotfix/2.13.4 to develop February 11, 2025 17:32
@hyunnaye
Copy link
Contributor Author

closing to create new pr to target hotfix

@hyunnaye hyunnaye closed this Feb 11, 2025
@hyunnaye hyunnaye deleted the feature/SEAB-6917 branch February 11, 2025 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants