Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix search smoke tests in staging and prod #2062

Merged
merged 3 commits into from
Feb 14, 2025
Merged

Conversation

kathy-t
Copy link
Contributor

@kathy-t kathy-t commented Feb 14, 2025

Description
This PR fixes the failed search page tests in staging and prod. PR #2055 added search cards in QA and modified the smoke tests, which caused the smoke tests to fail in staging and prod because those search card elements don't exist. I'll create a follow-up ticket to remove the staging/prod code when the search cards are deployed to staging and prod.

Review Instructions
Smoke tests should pass

Issue
n/a

Security
If there are any concerns that require extra attention from the security team, highlight them here.

Please make sure that you've checked the following before submitting your pull request. Thanks!

  • Check that your code compiles by running npm run build
  • Ensure that the PR targets the correct branch. Check the milestone or fix version of the ticket.
  • If this is the first time you're submitting a PR or even if you just need a refresher, consider reviewing our style guide
  • Do not bypass Angular sanitization (bypassSecurityTrustHtml, etc.), or justify why you need to do so
  • If displaying markdown, use the markdown-wrapper component, which does extra sanitization
  • Do not use cookies, although this may change in the future
  • Run npm audit and ensure you are not introducing new vulnerabilities
  • Do due diligence on new 3rd party libraries, checking for CVEs
  • Don't allow user-uploaded images to be served from the Dockstore domain
  • If this PR is for a user-facing feature, create and link a documentation ticket for this feature (usually in the same milestone as the linked issue). Style points if you create a documentation PR directly and link that instead.
  • Check whether this PR disables tests. If it legitimately needs to disable a test, create a new ticket to re-enable it in a specific milestone.

@kathy-t kathy-t self-assigned this Feb 14, 2025
Copy link

codecov bot commented Feb 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 41.78%. Comparing base (1959db4) to head (bfb4196).
Report is 1 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #2062   +/-   ##
========================================
  Coverage    41.78%   41.78%           
========================================
  Files          390      390           
  Lines        12321    12321           
  Branches      2946     2946           
========================================
  Hits          5148     5148           
  Misses        4870     4870           
  Partials      2303     2303           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kathy-t kathy-t merged commit 8f4c4a0 into develop Feb 14, 2025
25 of 26 checks passed
@kathy-t kathy-t deleted the feature/fix-smoke-tests branch February 14, 2025 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants