-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix auto DOI opt out instruction typo and make it bold #2064
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## hotfix/2.13.5 #2064 +/- ##
==============================================
Coverage 41.81% 41.81%
==============================================
Files 394 394
Lines 12330 12330
Branches 2960 2960
==============================================
Hits 5156 5156
Misses 4854 4854
Partials 2320 2320 ☔ View full report in Codecov by Sentry. |
@@ -29,9 +29,9 @@ <h1 mat-dialog-title>Manage DOIs</h1> | |||
Dockstore automatically creates a DOI for each valid, tagged version of this {{ entryTypeMetadata.term }} if it is published. It |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Whilst testing, I got tripped up by the "at least one author" requirement, which I wasn't aware of (not sure if I'd ever known or just forgotten). So, maybe we can ad some text that alludes to it here, something like "and has information about at least one author".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added that at least one author is required. Screenshots are updated in the PR description
|
Description
This PR fixes the typo in the auto DOI generation opt out instruction for GitHub App entries. This PR also bolds that instruction to make it more prominent and specifies that an author is required.
Before:

After:

Review Instructions
See #2059
Issue
https://ucsc-cgl.atlassian.net/browse/SEAB-6807
Security
If there are any concerns that require extra attention from the security team, highlight them here.
Please make sure that you've checked the following before submitting your pull request. Thanks!
npm run build
markdown-wrapper
component, which does extra sanitizationnpm audit
and ensure you are not introducing new vulnerabilities