Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix auto DOI opt out instruction typo and make it bold #2064

Merged
merged 3 commits into from
Feb 18, 2025

Conversation

kathy-t
Copy link
Contributor

@kathy-t kathy-t commented Feb 14, 2025

Description
This PR fixes the typo in the auto DOI generation opt out instruction for GitHub App entries. This PR also bolds that instruction to make it more prominent and specifies that an author is required.

Before:
image

After:
Screenshot 2025-02-18 at 13-44-09 Dockstore My Workflows

Review Instructions
See #2059

Issue
https://ucsc-cgl.atlassian.net/browse/SEAB-6807

Security
If there are any concerns that require extra attention from the security team, highlight them here.

Please make sure that you've checked the following before submitting your pull request. Thanks!

  • Check that your code compiles by running npm run build
  • Ensure that the PR targets the correct branch. Check the milestone or fix version of the ticket.
  • If this is the first time you're submitting a PR or even if you just need a refresher, consider reviewing our style guide
  • Do not bypass Angular sanitization (bypassSecurityTrustHtml, etc.), or justify why you need to do so
  • If displaying markdown, use the markdown-wrapper component, which does extra sanitization
  • Do not use cookies, although this may change in the future
  • Run npm audit and ensure you are not introducing new vulnerabilities
  • Do due diligence on new 3rd party libraries, checking for CVEs
  • Don't allow user-uploaded images to be served from the Dockstore domain
  • If this PR is for a user-facing feature, create and link a documentation ticket for this feature (usually in the same milestone as the linked issue). Style points if you create a documentation PR directly and link that instead.
  • Check whether this PR disables tests. If it legitimately needs to disable a test, create a new ticket to re-enable it in a specific milestone.

@kathy-t kathy-t self-assigned this Feb 14, 2025
Copy link

codecov bot commented Feb 18, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 41.81%. Comparing base (afe3bd7) to head (e4e94a0).
Report is 1 commits behind head on hotfix/2.13.5.

Additional details and impacted files
@@              Coverage Diff               @@
##           hotfix/2.13.5    #2064   +/-   ##
==============================================
  Coverage          41.81%   41.81%           
==============================================
  Files                394      394           
  Lines              12330    12330           
  Branches            2960     2960           
==============================================
  Hits                5156     5156           
  Misses              4854     4854           
  Partials            2320     2320           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@@ -29,9 +29,9 @@ <h1 mat-dialog-title>Manage DOIs</h1>
Dockstore automatically creates a DOI for each valid, tagged version of this {{ entryTypeMetadata.term }} if it is published. It
Copy link
Contributor

@svonworl svonworl Feb 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whilst testing, I got tripped up by the "at least one author" requirement, which I wasn't aware of (not sure if I'd ever known or just forgotten). So, maybe we can ad some text that alludes to it here, something like "and has information about at least one author".

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added that at least one author is required. Screenshots are updated in the PR description

@kathy-t kathy-t requested a review from svonworl February 18, 2025 18:48
@kathy-t kathy-t merged commit 2126471 into hotfix/2.13.5 Feb 18, 2025
17 of 19 checks passed
@kathy-t kathy-t deleted the seab-6807/demo-feedback branch February 18, 2025 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants