Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Removal of flags for language choice drop-down #2468

Merged
merged 3 commits into from
Jul 20, 2024

Conversation

akshaybhinge19
Copy link
Contributor

Summary

Country specific flags should not be associated with language choices.
Solution: List of languages without flags

Related issue, if any:

#2458

What kind of change does this PR introduce?

Feature

For any code change,

  • Related documentation has been updated, if needed
  • Related tests have been added or updated, if needed

Does this PR introduce a breaking change?

No

Tested in the following browsers:

  • Chrome
  • Firefox
  • Safari
  • Edge

Copy link

vercel bot commented Jul 18, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docsify-preview ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 19, 2024 5:12pm

@akshaybhinge19 akshaybhinge19 marked this pull request as ready for review July 18, 2024 12:36
@akshaybhinge19 akshaybhinge19 changed the title fix: Removal of flags for language choice drop-down #2458 fix: Removal of flags for language choice drop-down Jul 18, 2024
Copy link
Member

@Koooooo-7 Koooooo-7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @akshaybhinge19 , thx for your contribution.
As I mentioned, we do the translation refinement for the v5 release now.
This change gonna be suspended for now.

@akshaybhinge19
Copy link
Contributor Author

akshaybhinge19 commented Jul 19, 2024

Hi @akshaybhinge19 , thx for your contribution. As I mentioned, we do the translation refinement for the v5 release now. This change gonna be suspended for now.

@Koooooo-7 Thanks for the update. Sorry, I misunderstood it as being under the 5.x milestone. Can we update this?

image

@sy-records sy-records marked this pull request as draft July 19, 2024 07:59
@sy-records sy-records added docs related to the documentation of docsify itself do not merge labels Jul 19, 2024
@sy-records
Copy link
Member

Thank you for your contribution.
I've set it as a draft for now and will merge it in when we're sure.

@jhildenbiddle
Copy link
Member

@sy-records @Koooooo-7 --

I think we can safely merge this PR. It's just removing flag emojis. The changes will be merged to develop which already has v5-related doc updates, so we won't merge develop into main until v5 is ready anyway.

@jhildenbiddle jhildenbiddle marked this pull request as ready for review July 19, 2024 16:59
@sy-records sy-records changed the title fix: Removal of flags for language choice drop-down docs: Removal of flags for language choice drop-down Jul 20, 2024
@sy-records sy-records merged commit 1e9d2f0 into docsifyjs:develop Jul 20, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs related to the documentation of docsify itself
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants