Add support for cross om references. #625
Conversation
|
looks great ! thanks |
[WIP] Add support for cross om references.
|
Yep. I think you're right @jwage, I've seen this before :) |
|
it would be good to also support other ODMs. see also https://github.com/netvlies/DoctrineBridgeBundle /cc @markri |
| public function getManager($type) | ||
| { | ||
| return $this->managers[$type]; | ||
| } |
There was a problem hiding this comment.
Wouldn't it be better to register several ManagerRegistry instances (one for the ORM, one for the MongoDB ODM and so on) rather than registering managers directly ? It would keep them lazy-loaded.
There was a problem hiding this comment.
yes .. especially once multiple ODMs are supported. also it might even make sense to allow to define a manager name. this way one could even map between two separate EntityMangers.
There was a problem hiding this comment.
Well, currently, you can (using orm_1 and orm_2 as type).
Once it is switched to registries, this could be supported without the explicit name by using getManagerForClass (but it will be a bit less efficient than knowing the manager name)
There was a problem hiding this comment.
Yes, that would be much better. This code was originally written > 2 years ago so it pre-dates the ManagerRegistry. I hope to spend more time on this soon.
|
@lsmith77 References to other ODMs should already work if you register them (to be tested though). References from other ODMs would require implementing the appropriate adapters in the extension to support them. |
|
I tried the cross reference extension with the code provided by @Devlopnet here: I guess I am missing some kind of configuration to make my server aware of the |
We use this @opensky and it has been quite useful for us. I finally got some time to clean it up a little and contribute it back upstream. Originally written by @avalanche123 and I am pretty sure @jmikola and @bobthecow may have worked on it.