Trim quotes in unqualified foreign table names when diffing foreign keys #6773
+55
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cristi-contiu
changed the title
cristi-contiu
changed the title
cristi-contiu
changed the title
cristi-contiu
force-pushed
the
fix_postgres_foreign_key_table_custom_schema_reserverd_word
branch
from
b0de455 to
d0c53b4
Compare
greg0ire
reviewed
Feb 13, 2025
cristi-contiu
force-pushed
the
fix_postgres_foreign_key_table_custom_schema_reserverd_word
branch
from
056a8be to
a009e2c
Compare
greg0ire
previously approved these changes
Feb 14, 2025
…eserved word and in a custom schema
cristi-contiu
force-pushed
the
fix_postgres_foreign_key_table_custom_schema_reserverd_word
branch
from
a009e2c to
ad1b24a
Compare
greg0ire
approved these changes
Feb 14, 2025
SenseException
approved these changes
Feb 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Trims the quotes in
ForeignKeyConstraint::getUnqualifiedForeignTableName, only if quoted. Used inComparator::diffForeignKeywhen comparing foreign keys for changes. Fixes dropping and re-adding of foreign keys when foreign table name is simultaneously a reserved word (quoted) and in a non-default schema (not in default search path schemas).