Fix commit order computation for self-referencing entities with appli…

…cation-provided IDs

This excludes such associations from the commit order computation, since the foreign key constraint will be satisfied when inserting the row.

See #10735 for more details about this edge case.

lib/Doctrine/ORM/UnitOfWork.php

@@ -1315,6 +1315,14 @@ private function computeInsertExecutionOrder(): array
                     continue;
                 }
 
+                // An entity that references back to itself _and_ uses an application-provided ID
+                // (the "NONE" generator strategy) can be exempted from commit order computation.
+                // See https://github.com/doctrine/orm/pull/10735/ for more details on this edge case.
+                // A non-NULLable self-reference would be a cycle in the graph.
+                if ($targetEntity === $entity && $class->isIdentifierNatural()) {
+                    continue;
+                }
+
                 // According to https://www.doctrine-project.org/projects/doctrine-orm/en/2.14/reference/annotations-reference.html#annref_joincolumn,
                 // the default for "nullable" is true. Unfortunately, it seems this default is not applied at the metadata driver, factory or other
                 // level, but in fact we may have an undefined 'nullable' key here, so we must assume that default here as well.