Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/Self deprecation with getQueryCacheImpl #10856

Merged
merged 3 commits into from
Jul 26, 2023
Merged

Fix/Self deprecation with getQueryCacheImpl #10856

merged 3 commits into from
Jul 26, 2023

Conversation

VincentLanglet
Copy link
Contributor

@VincentLanglet VincentLanglet commented Jul 26, 2023 •
edited
Loading

Hi @greg0ire, I got another "non solvable deprecation" from doctrine.

getQueryCacheImpl is used in QueryCommand::execute

@greg0ire
Copy link
Member

greg0ire commented Jul 26, 2023 •
edited
Loading

Looking at that command, it looks like it could be reworked to avoid calls to that method when $cache is not null. I'm assuming you cannot configure both a psr/cache and a doctrine/cache, but that might be a wrong assumption, please check.

@greg0ire greg0ire added this to the 2.15.5 milestone Jul 26, 2023
@greg0ire greg0ire merged commit 24df74d into doctrine:2.15.x Jul 26, 2023
41 checks passed
@greg0ire
Copy link
Member

Thanks @VincentLanglet !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@greg0ire greg0ire greg0ire approved these changes

@SenseException SenseException SenseException approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.15.5
Development

Successfully merging this pull request may close these issues.
3 participants
@VincentLanglet @greg0ire @SenseException