Allow to skip property type validation #11130
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
greg0ire
approved these changes
Dec 20, 2023
|
Thank you @derrabus , I had to deactivate |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #11073 (comment) for context.
#10946 introduced validation of property types for the
ValidateSchemaCommand. For existing projects, this new feature might uncover quite a few valid problems, that need a little time to fix. This is problematic because if schema validation is run in CI, a project basically can't upgrade until all of the newly discovered errors have been fixed. This leaves two options:Both strategies are not desirable which is why I propose to add a flag to the command that allows us to opt out of the validation of property types. This allows this kind of projects to upgrade to 2.17 and fix the type mismatches iteratively.