-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix templated phpdoc return type #11407
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VincentLanglet
force-pushed
the
fixPhpdoc
branch
from
March 31, 2024 16:40
c25b013
to
8c6c1f4
Compare
derrabus
approved these changes
Apr 1, 2024
derrabus
added a commit
to derrabus/orm
that referenced
this pull request
Apr 15, 2024
* 2.19.x: Fix BIGINT validation (doctrine#11414) Fix templated phpdoc return type (doctrine#11407) [Documentation] Merging "Query Result Formats" with "Hydration Modes" Fix psalm errors: remove override of template type Update dql-doctrine-query-language.rst Adding `NonUniqueResultException` [Documentation] Query Result Formats
derrabus
added a commit
to derrabus/orm
that referenced
this pull request
Apr 15, 2024
* 2.19.x: Fix BIGINT validation (doctrine#11414) Fix templated phpdoc return type (doctrine#11407) [Documentation] Merging "Query Result Formats" with "Hydration Modes" Fix psalm errors: remove override of template type Update dql-doctrine-query-language.rst Adding `NonUniqueResultException` [Documentation] Query Result Formats
derrabus
added a commit
to derrabus/orm
that referenced
this pull request
Apr 15, 2024
* 2.19.x: Fix BIGINT validation (doctrine#11414) Fix templated phpdoc return type (doctrine#11407) [Documentation] Merging "Query Result Formats" with "Hydration Modes" Fix psalm errors: remove override of template type Update dql-doctrine-query-language.rst Adding `NonUniqueResultException` [Documentation] Query Result Formats
derrabus
added a commit
to derrabus/orm
that referenced
this pull request
Apr 15, 2024
* 2.19.x: Fix BIGINT validation (doctrine#11414) Fix templated phpdoc return type (doctrine#11407) [Documentation] Merging "Query Result Formats" with "Hydration Modes" Fix psalm errors: remove override of template type Update dql-doctrine-query-language.rst Adding `NonUniqueResultException` [Documentation] Query Result Formats
derrabus
added a commit
that referenced
this pull request
Apr 15, 2024
* 2.19.x: Fix BIGINT validation (#11414) Fix templated phpdoc return type (#11407) [Documentation] Merging "Query Result Formats" with "Hydration Modes" Fix psalm errors: remove override of template type Update dql-doctrine-query-language.rst Adding `NonUniqueResultException` [Documentation] Query Result Formats
derrabus
added a commit
that referenced
this pull request
Apr 15, 2024
* 3.1.x: Revert "Merge pull request #11399 from ThomasLandauer/issue-11377" (#11415) Fix BIGINT validation (#11414) docs: update PHP version in doc Fix fromMappingArray definition Fix templated phpdoc return type (#11407) [Documentation] Merging "Query Result Formats" with "Hydration Modes" SchemaValidator: Changing mapping of BIGINT to string|int Fix psalm errors: remove override of template type Update dql-doctrine-query-language.rst Adding `NonUniqueResultException` [Documentation] Query Result Formats
derrabus
added a commit
that referenced
this pull request
Apr 15, 2024
* 3.2.x: Revert "Merge pull request #11399 from ThomasLandauer/issue-11377" (#11415) Fix BIGINT validation (#11414) docs: update PHP version in doc Fix fromMappingArray definition Fix templated phpdoc return type (#11407) [Documentation] Merging "Query Result Formats" with "Hydration Modes" SchemaValidator: Changing mapping of BIGINT to string|int Fix psalm errors: remove override of template type Update dql-doctrine-query-language.rst Adding `NonUniqueResultException` [Documentation] Query Result Formats
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should be a better fix than #10849 cc @mvorisek @derrabus @greg0ire
See https://phpstan.org/r/6b0c3d58-199c-472a-91d0-0e9b09efc21d