Fix matching lazy collections with enums criteria #11516
Conversation
kira0269
force-pushed
the
fix_issue_11481
branch
5 times, most recently
from
d38e933
to
f9dbfdf
Compare
|
Please find a meaningful title for your PR. We use the titles in our automatically composed change log. |
kira0269
changed the title
kira0269
changed the title
|
Hello @derrabus |
|
Up @derrabus . This PR is still stuck because of your ghost request change 😢 |
|
Hi, I've got these issues from Psalm: And I don't understand what it means... I don't know how to fix those "issues". Thanks for your help. |
|
Your changes seem to have removed code with psalm issues that is still ignored in the psalm baseline and don't need to be anymore. If you find the affected lines in the XML for |
kira0269
force-pushed
the
fix_issue_11481
branch
from
5e312cc
to
adf4a53
Compare
|
Hi @derrabus I don't know why, but the merging is blocked because of a change you requested on one of the commits of this branch. Thanks a lot. |
| $paramTypes[] = PersisterHelper::getTypeOfField($name, $targetClass, $this->em)[0]; | ||
| } | ||
| } | ||
|
|
||
| $params = array_merge($params, ...$paramsValues); | ||
| unset($paramsValues); |
There was a problem hiding this comment.
Please remove this unset, its not needed.
| $this->_em->flush(); | ||
| $libraryId = $library->id; | ||
|
|
||
| unset($library, $redBook, $blueBook); |
There was a problem hiding this comment.
Please remove this unset, its not needed.
| $this->_em->flush(); | ||
| $libraryId = $library->id; | ||
|
|
||
| unset($library, $redBook, $blueBook); |
There was a problem hiding this comment.
Please remove this unset, its not needed.
| $thrillerCategoryId = $thrillerCategory->id; | ||
|
|
||
| $this->_em->clear(); | ||
| unset($thrillerCategory, $fantasyCategory, $blueBook, $redBook); |
There was a problem hiding this comment.
Please remove this unset, its not needed.
| $thrillerCategoryId = $thrillerCategory->id; | ||
|
|
||
| $this->_em->clear(); | ||
| unset($thrillerCategory, $fantasyCategory, $blueBook, $redBook); |
There was a problem hiding this comment.
Please remove this unset, its not needed.
|
|
||
| public function getBooksWithColor(BookColor $bookColor): Collection | ||
| { | ||
| $criteria = Criteria::create() |
There was a problem hiding this comment.
I'd prefer if you move this code into the test, because reading the test code now its not easy to grasp how test name matches to code. Same for the other Criteria code in Library.
Fix issue #11481
I identified some duplicated code between the
BasicEntityPersisterand theManyToManyPersister, like the methodexpandCriteriaParameters.Because I don't want to create side effects, I just factorized two methods :
getValuesandgetIndividualValueinto a trait.Thanks for your review !