Resolve LSP violation

[greg0ire]

This was necessary to support usage of static reflection, which is gone
with ORM 3.

[greg0ire]

@stof Psalm now rightfully complains about this line:

orm/src/Mapping/ClassMetadata.php

Line 785 in 1153b94

$this->reflClass = $reflService->getClass($this->name);

What should I do?

More broadly, is https://github.com/doctrine/persistence/blob/3.3.x/src/Persistence/Mapping/StaticReflectionService.php still needed? Should null be removed from the return type of https://github.com/doctrine/persistence/blob/b337726451f5d530df338fc7f68dee8781b49779/src/Persistence/Mapping/ReflectionService.php#L51-L56 ?

[greg0ire]

Related to doctrine/persistence#379

[github-actions]

There hasn't been any activity on this pull request in the past 90 days, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 7 days.
If you want to continue working on it, please leave a comment.

[greg0ire]

Looks like the issue I was concerned about was resolved in doctrine/persistence#381. I think I need to work on releasing persistence 4.0.0 before working on this 🤔