Skip to content

Commit

Permalink
Changes necessary for compatibility with ORM 3
Browse files Browse the repository at this point in the history
  • Loading branch information
greg0ire committed Jun 19, 2024
1 parent 40cbf43 commit dfdf93b
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 4 deletions.
2 changes: 1 addition & 1 deletion src/Persistence/Mapping/ClassMetadata.php
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ public function getIdentifier(): array;
*
* @return ReflectionClass<T>
*/
public function getReflectionClass(): ReflectionClass;
public function getReflectionClass();

Check failure on line 38 in src/Persistence/Mapping/ClassMetadata.php

View workflow job for this annotation

GitHub Actions / Coding Standards / Coding Standards (8.3)

Method \Doctrine\Persistence\Mapping\ClassMetadata::getReflectionClass() does not have native return type hint for its return value but it should be possible to add it based on @return annotation "ReflectionClass<T>".

/** Checks if the given field name is a mapped identifier for this class. */
public function isIdentifier(string $fieldName): bool;
Expand Down
4 changes: 2 additions & 2 deletions src/Persistence/Mapping/Driver/FileDriver.php
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@ public function getGlobalBasename(): string
*
* @throws MappingException
*/
public function getElement(string $className): ClassMetadata
public function getElement(string $className)

Check failure on line 74 in src/Persistence/Mapping/Driver/FileDriver.php

View workflow job for this annotation

GitHub Actions / Coding Standards / Coding Standards (8.3)

Method \Doctrine\Persistence\Mapping\Driver\FileDriver::getElement() does not have native return type hint for its return value but it should be possible to add it based on @return annotation "ClassMetadata".
{
if ($this->classCache === null) {
$this->initialize();
Expand Down Expand Up @@ -139,7 +139,7 @@ public function getAllClassNames(): array
* @return ClassMetadata[]
* @psalm-return array<class-string, ClassMetadata<object>>
*/
abstract protected function loadMappingFile(string $file): array;
abstract protected function loadMappingFile(string $file);

Check failure on line 142 in src/Persistence/Mapping/Driver/FileDriver.php

View workflow job for this annotation

GitHub Actions / Coding Standards / Coding Standards (8.3)

Method \Doctrine\Persistence\Mapping\Driver\FileDriver::loadMappingFile() does not have native return type hint for its return value but it should be possible to add it based on @return annotation "ClassMetadata[]".

/**
* Initializes the class cache from all the global files.
Expand Down
2 changes: 1 addition & 1 deletion src/Persistence/Proxy.php
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ interface Proxy
*
* Acts as a no-op if already initialized.
*/
public function __load(): void;
public function __load();

Check failure on line 29 in src/Persistence/Proxy.php

View workflow job for this annotation

GitHub Actions / Static Analysis / PHPStan (8.3)

Method Doctrine\Persistence\Proxy::__load() has no return type specified.

Check failure on line 29 in src/Persistence/Proxy.php

View workflow job for this annotation

GitHub Actions / Coding Standards / Coding Standards (8.3)

Method \Doctrine\Persistence\Proxy::__load() does not have void return type hint.

/** Returns whether this proxy is initialized or not. */
public function __isInitialized(): bool;
Expand Down

0 comments on commit dfdf93b

Please sign in to comment.