Add support for enum arguments to setValue() #343
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
greg0ire
requested review from
derrabus,
IonBazan,
SenseException and
malarzm
malarzm
reviewed
Feb 28, 2024
| @@ -86,13 +86,25 @@ private function fromEnum($enum) | |||
| } | |||
|
|
|||
| /** | |||
| * @param int|string|int[]|string[] $value | |||
| * @param int|string|int[]|string[]|BackedEnum|BackedEnum[] $value | |||
| * | |||
| * @return ($value is int|string ? BackedEnum : BackedEnum[]) | |||
There was a problem hiding this comment.
Suggested change
| * @return ($value is int|string ? BackedEnum : BackedEnum[]) | |
| * @return ($value is int|string|BackedEnum ? BackedEnum : BackedEnum[]) |
This should take down one SA baseline entry
There was a problem hiding this comment.
Didn't seem to, but good point anyway.
| if (is_array($value)) { | ||
| foreach ($value as $v) { |
There was a problem hiding this comment.
This was hard to read for me (maybe because I'm in vacations-mode ;)... IMO using reset would be more elegant than this entire loop
The ORM is relying on that feature.
greg0ire
force-pushed
the
add-support-for-set-value-with-enum
branch
from
a102634
to
e70bc39
Compare
SenseException
approved these changes
Feb 28, 2024
malarzm
approved these changes
Feb 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ORM is relying on that feature.
When trying to use
EnumReflectionPropertyinstead of the corresponding class, the test suite breaks on this line: https://github.com/doctrine/orm/blob/b187bc85881cc85d36b28e7ed9dbe2071d472e30/src/UnitOfWork.php#L2406EnumReflectionPropertywas added #248 so that it could reduce duplication with the ORM, but is not used yet.