Implement isUninitializedObject() in ObjectManagerDecorator #369
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
greg0ire
force-pushed
the
implement-is-uninitialized
branch
2 times, most recently
from
2fe2930
to
d600776
Compare
derrabus
reviewed
May 22, 2024
greg0ire
force-pushed
the
implement-is-uninitialized
branch
3 times, most recently
from
028216b
to
4ca86df
Compare
greg0ire
force-pushed
the
implement-is-uninitialized
branch
from
4ca86df
to
9c9c61a
Compare
greg0ire
commented
May 22, 2024
| @@ -30,7 +30,7 @@ | |||
| "phpstan/phpstan-strict-rules": "^1.1", | |||
| "doctrine/coding-standard": "^12", | |||
| "doctrine/common": "^3.0", | |||
| "phpunit/phpunit": "^8.5 || ^9.5", | |||
| "phpunit/phpunit": "^8.5.38 || ^9.5", | |||
There was a problem hiding this comment.
old versions of PHPUnit seem to struggle with @requires annotation that are included in a single-line comment.
greg0ire
force-pushed
the
implement-is-uninitialized
branch
2 times, most recently
from
813353a
to
2f0e733
Compare
That method will be part of the ObjectManager interface in 4.0.x.
greg0ire
force-pushed
the
implement-is-uninitialized
branch
from
2f0e733
to
0adca4c
Compare
SenseException
approved these changes
May 23, 2024
| throw new BadMethodCallException(sprintf( | ||
| <<<'EXCEPTION' | ||
| Context: Trying to call %s | ||
| Problem: The wrapped ObjectManager, an instance of %s does not implement this method. |
There was a problem hiding this comment.
__METHOD__ does also contain the FQCN. You could shorten the "instance of" Exception text if you like.
There was a problem hiding this comment.
Not really, since the FQCN at hand is not the same as the one referred to in the "Problem" part. In the context part, I say we are calling the decorator, in the problem part, I talk about the decorated class.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
That method will be part of the ObjectManager interface in 4.0.x.
It was introduced in #334