Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove StaticReflectionService #381

Merged
merged 1 commit into from
Jun 24, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions UPGRADE.md
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,16 @@ awareness about deprecated code.

# Upgrade to 4.0

## BC Break: Removed `StaticReflectionService`

The class `Doctrine\Persistence\Mapping\StaticReflectionService` is removed
without replacement.

## BC Break: Narrowed `ReflectionService::getClass()` return type

The return type of `ReflectionService::getClass()` has been narrowed so that
`null` is no longer a valid return value.

## BC Break: Added `ObjectManager::isUninitializedObject()`

Classes implementing `Doctrine\Persistence\ObjectManager` must implement this
Expand Down
4 changes: 2 additions & 2 deletions src/Persistence/Mapping/ReflectionService.php
Original file line number Diff line number Diff line change
Expand Up @@ -42,11 +42,11 @@ public function getClassNamespace(string $class): string;
*
* @psalm-param class-string<T> $class
*
* @psalm-return ReflectionClass<T>|null
* @psalm-return ReflectionClass<T>
*
* @template T of object
*/
public function getClass(string $class): ReflectionClass|null;
public function getClass(string $class): ReflectionClass;

/**
* Returns an accessible property (setAccessible(true)) or null.
Expand Down
67 changes: 0 additions & 67 deletions src/Persistence/Mapping/StaticReflectionService.php

This file was deleted.

51 changes: 0 additions & 51 deletions tests/Persistence/Mapping/StaticReflectionServiceTest.php

This file was deleted.