Maintenance #389
Maintenance #389
Conversation
greg0ire
force-pushed
the
maintenance
branch
2 times, most recently
from
830bd1a
to
42922a0
Compare
| /** | ||
| * {@inheritDoc} | ||
| * | ||
| * @psalm-external-mutation-free |
There was a problem hiding this comment.
PHPStan apparently doesn't understand that annotation, but then again, it does not complain when it is gone.
There was a problem hiding this comment.
I don't understand why it was used for those getters.
There was a problem hiding this comment.
phpstan memoizes getters by default unless tagged with @phpstan-impure, while psalm does not. This @psalm-external-mutation-free is required for Psalm to consider that calling a method does not mutate other things and so it can remember refinements it did for calls.
| * @psalm-suppress ArgumentTypeCoercion | ||
| * @psalm-suppress UndefinedClass | ||
| * @phpstan-suppress ArgumentTypeCoercion | ||
| * @phpstan-suppress UndefinedClass |
There was a problem hiding this comment.
Suppressing a psalm error with a phpstan-suppress annotation does not make any sense. @phpstan-suppress does not exist (the equivalent feature in phpstan uses the @phpstan-ignore-* tags, as used just below)
| /** | ||
| * {@inheritDoc} | ||
| * | ||
| * @psalm-external-mutation-free |
There was a problem hiding this comment.
phpstan memoizes getters by default unless tagged with @phpstan-impure, while psalm does not. This @psalm-external-mutation-free is required for Psalm to consider that calling a method does not mutate other things and so it can remember refinements it did for calls.
No description provided.