Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Adding sops feature #143

Merged
merged 1 commit into from
Jun 21, 2024
Merged

feat: Adding sops feature #143

merged 1 commit into from
Jun 21, 2024

Conversation

timdeluxe
Copy link
Member

No description provided.

@timdeluxe timdeluxe added the enhancement New feature or request label Jun 13, 2024
@timdeluxe timdeluxe self-assigned this Jun 13, 2024
@timdeluxe timdeluxe requested a review from a team as a code owner June 13, 2024 12:58
dploeger
dploeger approved these changes Jun 13, 2024
View reviewed changes
Copy link
Member

@dploeger dploeger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. Thanks! 🎁

@timdeluxe
Copy link
Member Author

@ThomasMinor or @rexhinvorpsi i need two approvals, can one of you check and approve this as well please? Thanks!

@rexhinvorpsi rexhinvorpsi self-requested a review June 21, 2024 07:04
@ThomasMinor
Copy link
Member

Does the SOPS package contain the AGE package?

@timdeluxe
Copy link
Member Author

@ThomasMinor

Does the SOPS package contain the AGE package?

SOPS containts AGE libraries to work with AGE keys. It does not include the age CLI itself, but it can work with created keys. I wouldn't include the age cli as well, as it would unnecessarily bloat the container. Key creation is kind of a one time operation and can be done outside of cloudcontrol.

Can you approve as well please, so i know it is fine with you - even despite the fact that this PR already reached the 2 necessary approvals?

@ThomasMinor ThomasMinor self-requested a review June 21, 2024 12:16
@timdeluxe timdeluxe merged commit c355007 into develop Jun 21, 2024
12 checks passed
@dploeger dploeger deleted the feature/te/sops branch August 5, 2024 07:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dploeger dploeger dploeger approved these changes

@ThomasMinor ThomasMinor ThomasMinor approved these changes

@rexhinvorpsi rexhinvorpsi rexhinvorpsi approved these changes

Assignees

@timdeluxe timdeluxe

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@timdeluxe @ThomasMinor @dploeger @rexhinvorpsi