Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Added labels to all images #97

Merged
merged 8 commits into from
Nov 3, 2023
Merged

Conversation

dploeger
Copy link
Member

as required by Artifacthub
https://artifacthub.io/docs/topics/repositories/container-images/

I wanted to add CloudControl to the image container registry at Artifacthub, but they require certain labels. Introduced mo to do the dynamic labels in the Dockerfile.suffix

@timdeluxe
Copy link
Member

Mooo! 🐄
(sorry could not resist)

Does the suffix file also work without sending it through mo? This should work for local development on cloudcontrol (not replaced template placeholders shouldn't be an issue for local development). If it does not work, the suffix File should be rather a .mo file (like Dockerfile.suffix.mo), so that one is aware that the Dockerfile.suffix needs to be created first before using it.

@dploeger
Copy link
Member Author

@timdeluxe Yes. You're right. I've modified the workflow a bit to make this more clear.

Copy link
Member

@timdeluxe timdeluxe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 🎁

@dploeger
Copy link
Member Author

dploeger commented Nov 1, 2023

@ThomasMinor @timdeluxe Because of a lot of incompatibilities, version unavailabilities etc. this PR now also includes a rewrite of the CCC client in a current Vue version and a changed workflow for installing AWSsudo. :(

I hope, it's still review-able.

Copy link
Member

@timdeluxe timdeluxe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well it is kind of a new software now 😃
But couldn't find bigger issues and i guess you tested it already, so i am fine with it...

Copy link
Member

@ThomasMinor ThomasMinor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a lot for some labels :)

@dploeger dploeger merged commit df9650a into develop Nov 3, 2023
6 checks passed
@dploeger dploeger deleted the feature/dpr/artifacthub-labels branch November 14, 2023 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants