0.1.3 dev expose tools #143
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Really good, more utils the better -- I just do want to look at, in a simplification pass later, to not require the actual address of the chainparams pointer. That's a bit too "C native" for wide use, since the address of a pointer is going to at least have to be stored and recalled possibly in non-C languages, or via wrappers. It's OK for this because I'd rather it go in. but I want to constrain exposing users to pointers and mem addresses. It's just a point of failure and difficulty we could probably simplify away. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Exposes the tool functions to generate WIF keys and addresses and also updates the example.