Added address function generateDerivedHDPrivKeyWIF #146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In tool.c/tool.h/tool_tests.c hd_privkey_wif(hd_privkey, out_privkey_wif, inout_size) Convert a BIP32 extended private key to WIF format. In bip32.c/bip32.h/bip32_tests.c dogecoin_hdnode_serialize_privkey_wif(node, chain, outstr, strsize) Serialize private key from HD node as WIF private key string. In chainparams.c/chainparams.h chain_from_bip32_prefix(bip32extkey) Determine chainparams from BIP32 extended private or public key.
It makes more sense as an address function, and should be available to language wrappers the same as other address functions. Added documentation in address.md
raffecat
changed the title
raffecat
changed the title
|
Note - I have proposed renaming this function to |
Removed dogecoin_hdnode_serialize_privkey_wif.
|
Revised PR to use |
xanimo
approved these changes
Aug 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In address.c, generateDerivedHDPrivKeyWIF(extended_private, out_privkey_wif)
Converts an extended HD private address (dgpv, tprv) to a WIF-encoded private key.
In bip32.c, dogecoin_hdnode_serialize_privkey_wif(node, chain, outstr, strsize)Serialize the private key from a HD node as a WIF private key string.
In chainparams.c, chain_from_bip32_prefix(bip32extkey)Determine chainparams from a BIP32 extended private or public key.