-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added bip and private key utilities #148
Added bip and private key utilities #148
Conversation
2843527
to
3798439
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK, tested on x86_64-pc-linux-gnu.
OK to merge just TODO: later want to change this so it doesn't require a pointer and memory address reference because it cuts off accessibility to some other languages; want to retool it so that a chainparam is selected via an option/integer/value, not feeding it the chainparams pointer. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TODO: want libdogecoin api to eventually never require pointers, so should replace pointer addr input with parameter.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TODO: same here with pointer intake, should require main/regtest/testnet as option for chainparams not the actual chainparams structure address
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed, I'll work to wrap the functions with pointers so that they're not necessary.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving but with the caveat of later rework on needing to manipulate/send a pointer addr to use.
contrib: updated example
3798439
to
4d53e4b
Compare
Exposes bip32, bip44 and private key encoding utilities.