Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added bip and private key utilities #148

Merged

Conversation

edtubbs
Copy link
Collaborator

@edtubbs edtubbs commented Aug 1, 2023

Exposes bip32, bip44 and private key encoding utilities.

@edtubbs edtubbs force-pushed the 0.1.3-dev-fix-header-add-bips branch from 2843527 to 3798439 Compare August 1, 2023 01:19
Copy link
Member

@xanimo xanimo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK, tested on x86_64-pc-linux-gnu.

@michilumin
Copy link
Contributor

OK to merge just TODO: later want to change this so it doesn't require a pointer and memory address reference because it cuts off accessibility to some other languages; want to retool it so that a chainparam is selected via an option/integer/value, not feeding it the chainparams pointer.

@michilumin michilumin self-requested a review August 1, 2023 04:10
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TODO: want libdogecoin api to eventually never require pointers, so should replace pointer addr input with parameter.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TODO: same here with pointer intake, should require main/regtest/testnet as option for chainparams not the actual chainparams structure address

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed, I'll work to wrap the functions with pointers so that they're not necessary.

Copy link
Contributor

@michilumin michilumin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving but with the caveat of later rework on needing to manipulate/send a pointer addr to use.

contrib: updated example
@edtubbs edtubbs force-pushed the 0.1.3-dev-fix-header-add-bips branch from 3798439 to 4d53e4b Compare August 1, 2023 05:24
@xanimo xanimo merged commit ddd816b into dogecoinfoundation:0.1.3-dev Aug 2, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants